[LOGCXX-46] Extra semicolon after namespace closing paren

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.7
• Fix Version/s: 0.10.0
• Component/s: Build
• Assignee: Curt Arnold
• Reporter: Curt Arnold
• Created: 15/Dec/04 00:06
• Updated: 11/Feb/05 13:42
• Resolved: 11/Feb/05 13:42

Description

http://nagoya.apache.org/eyebrowse/ReadMsg?listName=[e-mail]&msgNo=569

From: Sluis, Minto van der <[e-mail]>
Subject: Removing trailing semicolon for namespaces.
Date: Mon, 13 Dec 2004 16:03:32 +0100
Content-Type: multipart/alternative;
boundary="----_=_NextPart_001_01C4E124.E95A7BB0"

Hi,

I tried to compile log4cxx for for tru64 using the compaq compiler.
Unfortunately I ran into a lot of compiler errors. Below is a script
to resolve a few of the errors. This script strips the trailing semi-
colon from namespace declarations.

for f in `find . -name "*.h"`; do
cp $f $f.original
sed -e "s/}; \/\/name/} \/\/ name/g" -e "s/}; \/\/ name/} \/\/
name/g" $f > $f.modified
mv $f.modified $f
done

For instance:

namespace log4cxx

{ ... }; // namespace

and

namespace log4cxx
{ ... }

; //namespace

gets converted to:

namespace log4cxx

{ ... }

// namespace

Many compilers do not mind the additional semi-colon, however since
building on tru64 automatically turns on strict ansi. This is results
is a lot of errors (warnings if strict ansi is turned of). Compile
output looks much cleaner with the semi-colons gone.

cheers,

Minto van der Sluis