Uploaded image for project: 'Log4cxx'
  1. Log4cxx
  2. LOGCXX-451

Application hang up during exit on Windows

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.11.0
    • 1.0.0
    • Configurator
    • None
    • Windows

    Description

      I use such code in one of my DLL in application:
      xml::DOMConfigurator::configureAndWatch("log4cxx.xml");
      PropertyConfigurator::configureAndWatch("log4cxx.properties");
      At this point watchdog threads are created and they are pushed to some container:
      void DOMConfigurator::configureAndWatch(const std::string& filename, long delay)
      {
      File file(filename);
      #if APR_HAS_THREADS
      if( xdog )

      { APRInitializer::unregisterCleanup(xdog); delete xdog; }

      xdog = new XMLWatchdog(file);
      APRInitializer::registerCleanup(xdog); < == watchdog pushed to container here
      xdog->setDelay(delay);
      xdog->start();
      #else
      DOMConfigurator().doConfigure(file, LogManager::getLoggerRepository());
      #endif
      }

      void APRInitializer::registerCleanup(FileWatchdog* watchdog) {
      APRInitializer& instance(getInstance());
      #if APR_HAS_THREADS
      synchronized sync(instance.mutex);
      #endif
      instance.watchdogs.push_back(watchdog);
      }

      But APRInitializer is a Singletone class which is allocated static.
      APRInitializer& APRInitializer::getInstance() {
      static APRInitializer init;
      return init;
      }

      Then my application stops and Dynamic Library, which uses log4cxx is unloaded in _CRT_INIT (which is called from DllMain) function destructor for APRInitializer object is called => and called destructors for watchdog objects.

      FileWatchdog::~FileWatchdog() {
      apr_atomic_set32(&interrupted, 0xFFFF);
      try

      { thread.interrupt(); thread.join(); }

      catch(Exception &e) {
      }
      }

      In thread.join() function WaitForSingleObject is called and we have deadlock, because when some thread execute DllMain code all other threads are slept by system.
      So, one thread wait when another will stop, but another thread is slept.

      Now it is impossible to call configureAndWatch from Dll.
      Please fix it?

      Attachments

        Activity

          People

            swebb2066 Stephen Webb
            Haster John.Rembo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: