[LOGCXX-399] Non-ascii character output wrong.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.10.0, 0.11.0
• Component/s: Appender
• Labels: patch
• Environment: Windows chinese
• Assignee: Curt Arnold
• Reporter: Jin Qing
• Created: 19/Nov/12 11:28
• Updated: 21/Mar/18 18:40
• Resolved: 21/Mar/18 12:43

Description

void main()
{
setlocale(LC_ALL, "");
...
LOG4CXX_INFO(pLog, "一二"); // log 2 chinese characters.
}

Log 2 Chinese characters but output 3 characters.

This error is caused by MbstowcsCharsetDecoder::decode().

size_t converted = mbsrtowcs(...
if (converted == (size_t) -1)

{ ... } else { stat = append(out, buf); in.position(in.position() + converted); // ERROR! }

mbsrtowcs() returns the number of wide char. In case of Chinese character, position should increase 2*converted.

My patch:

if (converted == (size_t) -1) { ... }

else

{ stat = append(out, buf); // in.position(in.position() + converted); // ERROR! if (src) in.position(src - in.data()); else // mbsrtowcs() set src to NULL. in.position(in.position() + strnlen(in.current(), in.remaining())); }

Issue Links

• duplicates: LOGCXX-369 Load Properties File Fails When There Are multibyte Characters in the Path
• links to: GitHub Pull Request #4