Log4cxx
  1. Log4cxx
  2. LOGCXX-32

Missing copy constructors and assignment operators

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.7
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Exception and derived classes contain a String member but are missing copy constructors and assignment operators (see Effective C++ item 11 for an explanation why this is a bad thing). This may affect other classes too. gcc has a -Weffc++ flag that can identify this and other violations of Effective C++ guidelines (however it is too strict and gives too many false errors for normal use).

        Activity

        Hide
        Curt Arnold added a comment -

        CVS commit message: http://nagoya.apache.org/eyebrowse/ReadMsg?listName=log4cxx-dev@logging.apache.org&msgNo=324

        Knocked off other gcc Effective C++ warnings including some innocuous ones (for example, using std::string::assign instead of operator=) just to get the list in better condition for subsequence reviews.

        Show
        Curt Arnold added a comment - CVS commit message: http://nagoya.apache.org/eyebrowse/ReadMsg?listName=log4cxx-dev@logging.apache.org&msgNo=324 Knocked off other gcc Effective C++ warnings including some innocuous ones (for example, using std::string::assign instead of operator=) just to get the list in better condition for subsequence reviews.

          People

          • Assignee:
            Curt Arnold
            Reporter:
            Curt Arnold
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development