Uploaded image for project: 'Log4cxx'
  1. Log4cxx
  2. LOGCXX-30

StringTokenizer uses evil strtok and wcstok functions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.7
    • Fix Version/s: 0.10.0
    • Component/s: Configurator
    • Labels:
      None

      Description

      Use of strtok and wcstok are discouraged, I quote from the man page for strtok:

      BUGS
      Never use these functions. If you do, note that:

      These functions modify their first argument.

      These functions cannot be used on constant strings.

      The identity of the delimiting character is lost.

      The strtok() function uses a static buffer while
      parsing, so it's not thread safe. Use strtok_r() if
      this matters to you.

      I discovered this after getting a report from valgrind that StringTokenizer used a delete where it should have used a delete [], however there is no reason just to fix that one problem.

      It should be trivial to rewrite using std::basic_string methods.

        Attachments

          Activity

            People

            • Assignee:
              carnold@apache.org Curt Arnold
              Reporter:
              carnold@apache.org Curt Arnold
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: