[LOGCXX-283] Suspicious, but harmless, reuse of LOCAL1 in SyslogAppender::getFacility

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Appender
• Assignee: Curt Arnold
• Reporter: Curt Arnold
• Created: 09/May/08 22:14
• Updated: 17/Jun/08 21:21
• Resolved: 17/Jun/08 21:21

Description

The implementation of SyslogAppender::getFacility has fragments like the following where you'd expect the uppercased facility name to be in sync with the lower case:

else if (StringHelper::equalsIgnoreCase(s, LOG4CXX_STR("LOCAL1"), LOG4CXX_STR("local1")))

{ return LOG_LOCAL1; }

else if (StringHelper::equalsIgnoreCase(s, LOG4CXX_STR("LOCAL1"), LOG4CXX_STR("local2")))

{ return LOG_LOCAL2; }

else if (StringHelper::equalsIgnoreCase(s, LOG4CXX_STR("LOCAL1"), LOG4CXX_STR("local3")))

{ return LOG_LOCAL3; }

However the unintentional reuse of LOCAL1 does not have any negative consequences.