Log4cxx
  1. Log4cxx
  2. LOGCXX-251

NDC::cloneStack and NDC::inherit missing in 0.10.0 RC2

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      On Mar 4, 2008, at 1:41 PM, Ufuk Kayserilioglu wrote on log4cxx-user:

      Whatever happened to the NDC functionality of "clone" and "inherit"? I would like to pass around a diagnostic context but the application I am working on is massively multi-threaded and most runs go through various worker-pool threads. Given the functionality of "clone" and "inherit", I was used to cloning the current threads NDC before I post a work-item, posting that along with the work-item, and when the worker-thread received the work-item I would "clear" and "inherit" the NDC for the recepient thread. That way I could always trace a single item throughout all my logs.

      Is there a specific reason for the removal of this functionalty? And, is it non-trivial to re-implement it?

      Regards,

      Ufuk Kayserilioglu

        Activity

        Hide
        Curt Arnold added a comment -

        Committed in rev 636964.

        Implementation is slightly different. 0.9.7 didn't isolate NDC content after the call to inherit, so it would be possible to modify NDC by manipulating the argument after the call to NDC::inherit. The new one copies the argument. Any manipulation after NDC::inherit will not have an effect on the NDC.

        Show
        Curt Arnold added a comment - Committed in rev 636964. Implementation is slightly different. 0.9.7 didn't isolate NDC content after the call to inherit, so it would be possible to modify NDC by manipulating the argument after the call to NDC::inherit. The new one copies the argument. Any manipulation after NDC::inherit will not have an effect on the NDC.

          People

          • Assignee:
            Curt Arnold
            Reporter:
            Curt Arnold
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development