Log4cxx
  1. Log4cxx
  2. LOGCXX-247

MSVC project has wrong additional include directories

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      MSVC 8 SP1
      Trying to build as detailed in: apache-log4cxx-0.10.0/site/building/vstudio.html
      Upgraded apache-log4cxx-0.10.0\projects\log4cxx.dsw to MSVC 8 SP1

      Description

      The additional include directories in the project are:
      ..\src\main\include,..\..\..\..\apr-1.2.11\include,..\..\..\..\apr-util-1.2.10\include

      APR and APR-UTIL shouldn't contain version numbers if the build instructions are followed.

      Furthermore the path for APR and APR-UTIL is two levels up (again according to the build instructions), not four levels as in the current project settings.

      The include directories should therefore be:
      ..\src\main\include;..\..\apr\include;"..\..\apr-util\include"

        Activity

        Hide
        Curt Arnold added a comment -

        Rolled back changes in find-apr.xml and find-apr-util.xml from rev 630402.

        Show
        Curt Arnold added a comment - Rolled back changes in find-apr.xml and find-apr-util.xml from rev 630402.
        Hide
        Curt Arnold added a comment -

        I let this slip in during release preparation.

        During "mvn release:perform" (which you do after "mvn release:prepare" which creates the release tag), Maven checks out a fresh copy in target/checkout and then rebuilds and creates the distribution assembly from that directory. After I first cut RC1, I ran into the problem that now there were two extra levels between the log4cxx directories and the release build would fail. I didn't think through all the consequences when I committed the changes to apr-find.xml and apr-util-find.xml in rev 630402 which will allow the script to find apr and apr-util either one, two or three levels down.

        The version numbers occurs since instead of following my instructions to rename the apr-1.2.x and apr-util-1.2.x directories on the release preparation VM, I symlinked them.

        I'm going to rollback the 630402 changes to find-apr.xml and find-apr-util.xml. I guess the release manager on future releases will have to do a manual step of expanding and renaming apr and apr-util in the target directory prior to "mvn release:perform"

        Show
        Curt Arnold added a comment - I let this slip in during release preparation. During "mvn release:perform" (which you do after "mvn release:prepare" which creates the release tag), Maven checks out a fresh copy in target/checkout and then rebuilds and creates the distribution assembly from that directory. After I first cut RC1, I ran into the problem that now there were two extra levels between the log4cxx directories and the release build would fail. I didn't think through all the consequences when I committed the changes to apr-find.xml and apr-util-find.xml in rev 630402 which will allow the script to find apr and apr-util either one, two or three levels down. The version numbers occurs since instead of following my instructions to rename the apr-1.2.x and apr-util-1.2.x directories on the release preparation VM, I symlinked them. I'm going to rollback the 630402 changes to find-apr.xml and find-apr-util.xml. I guess the release manager on future releases will have to do a manual step of expanding and renaming apr and apr-util in the target directory prior to "mvn release:perform"

          People

          • Assignee:
            Curt Arnold
            Reporter:
            Jean-François Bastien
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development