Uploaded image for project: 'Log4cxx'
  1. Log4cxx
  2. LOGCXX-235

Add ObjectPtrT::exchange

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.10.0
    • 0.10.0
    • None
    • None

    Description

      There are a number of casts to and from void* in ObjectPtrT which could be simplified by introducing a new member function to abstract away the casts so that they are only done in one place. The uses of ObjectPtrBase::exchange can be changed to the new function and so don't need any casts. To avoid any accidental ambiguity, the original ObjectPtrBase::exchange could be renamed (user code outside the library that uses that function directly would have to be changed to call the new typesafe function, or call the renamed original function)

      Attachments

        1. log4cxx-objectptr-235.patch
          2 kB
          Jonathan Wakely

        Activity

          People

            carnold@apache.org Curt Arnold
            jwakely Jonathan Wakely
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: