[LOGCXX-210] HTMLLayout NDC null check

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.10.0
• Component/s: Layout
• Environment: Kubuntu Linux 7.04, kernel 2.6.22-14-generic #1 SMP i686 GNU/Linux; g++ (GCC) 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)
• Assignee: Curt Arnold
• Reporter: Akadafukah
• Created: 25/Nov/07 18:51
• Updated: 05/Dec/07 21:05
• Resolved: 05/Dec/07 21:05

Description

htmllayout.cpp (line 128) has a bug when checking if ndc is null. Instead of:
if(event->getNDC().length() != 0)
it should be:
if(!NDC::isNull(event->getNDC()))

While using the HTMLLayout it's easily detected as 'NDC: null' appears.
I've just downloaded the last svn version, so I think the problem hasn't been solved jet.
Replacing line 128 and adding the ndc header:
#include <log4cxx/ndc.h>
are the only actiones needed to fix this bug; I've tested it and it works correctly – thou I only tested it without ndc.