[LOGCXX-133] Missing parenthesis in LOG4CXX_ASSERT

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.7
• Fix Version/s: 0.10.0
• Assignee: Curt Arnold
• Reporter: Curt Arnold
• Created: 12/Apr/06 00:11
• Updated: 12/Apr/06 00:15
• Resolved: 12/Apr/06 00:15

Description

On Apr 11, 2006, at 4:13 AM, Ondrej Pacovsky wrote:

Hi, I'd just like to note that the LOG4CXX_ASSERT macro might be a bit dangerous because of its usage of the "condition" param:

#define LOG4CXX_ASSERT(logger, condition, message) { \
if (!condition && logger->isErrorEnabled()) {\
logger->forcedLog(::log4cxx::Level::getError(), message, LOG4CXX_LOCATION); }}

when used e.g. as LOG4CXX_ASSERT(lmain, false || true, "damn"), it producess the error message when it shouldn't.

FIX: use parentheses
#define LOG4CXX_ASSERT(logger, condition, message) { \
if (!(condition) && logger->isErrorEnabled()) {\
logger->forcedLog(::log4cxx::Level::getError(), message, LOG4CXX_LOCATION); }}

cheers,
Ondrej