Uploaded image for project: 'Log4net'
  1. Log4net
  2. LOG4NET-540

nuget dependencies for .NET Standard leak into net46

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.6
    • Fix Version/s: 2.0.7
    • Component/s: Other
    • Labels:
    • Flags:
      Patch

      Issue Links

        Activity

        Hide
        bodewig Stefan Bodewig added a comment -

        The release process we use involves a vote that runs for three days. I kicked it off on Monday https://lists.apache.org/thread.html/b35a6c08c76ed7ee39a0fcabbd4f1c478f8787889858eacfcef73383@%3Clog4net-dev.logging.apache.org%3E - if nothing unusual happens the new package should get published about 25 hours from now.

        Show
        bodewig Stefan Bodewig added a comment - The release process we use involves a vote that runs for three days. I kicked it off on Monday https://lists.apache.org/thread.html/b35a6c08c76ed7ee39a0fcabbd4f1c478f8787889858eacfcef73383@%3Clog4net-dev.logging.apache.org%3E - if nothing unusual happens the new package should get published about 25 hours from now.
        Hide
        simoncropp Simon Cropp added a comment -

        Thanks. Any eta on the release?

        Show
        simoncropp Simon Cropp added a comment - Thanks. Any eta on the release?
        Hide
        bodewig Stefan Bodewig added a comment -

        Thank you. I'll start preparing a new release.

        Show
        bodewig Stefan Bodewig added a comment - Thank you. I'll start preparing a new release.
        Hide
        simoncropp Simon Cropp added a comment -

        Works on my machine

        Show
        simoncropp Simon Cropp added a comment - Works on my machine
        Hide
        bodewig Stefan Bodewig added a comment -

        Could anybody please give the package at https://www.myget.org/feed/log4net-test/package/nuget/log4net a try? If that works I'll restart the release process for 2.0.7 which will take a few days to complete.

        Show
        bodewig Stefan Bodewig added a comment - Could anybody please give the package at https://www.myget.org/feed/log4net-test/package/nuget/log4net a try? If that works I'll restart the release process for 2.0.7 which will take a few days to complete.
        Hide
        bodewig Stefan Bodewig added a comment -

        Empty dependencies for targets we support sounds a lot better, indeed. I'll create a test 2.0.7 NuGet package and publish it at myget so we can try whether that works, I'll report here once I'm done.

        Show
        bodewig Stefan Bodewig added a comment - Empty dependencies for targets we support sounds a lot better, indeed. I'll create a test 2.0.7 NuGet package and publish it at myget so we can try whether that works, I'll report here once I'm done.
        Hide
        adamralph Adam Ralph added a comment -

        Does it select the 4.5 assemblies rather than the .NET Standard ones, at least?

        Yes, it does.

        Perhaps it's enough to have an empty dependency list for those TFN's which you do support, e.g. net45-full. When installing in a net462 project, NuGet references the net45-full assemblies, so I expect it will be smart enough to also use the net45-full dependency list.

        AFAIK, the best practice is indeed to specify a dependency list for every single TFN supported by the package, including those TFN's which have no dependencies.

        Show
        adamralph Adam Ralph added a comment - Does it select the 4.5 assemblies rather than the .NET Standard ones, at least? Yes, it does. Perhaps it's enough to have an empty dependency list for those TFN's which you do support, e.g. net45-full. When installing in a net462 project, NuGet references the net45-full assemblies, so I expect it will be smart enough to also use the net45-full dependency list. AFAIK, the best practice is indeed to specify a dependency list for every single TFN supported by the package, including those TFN's which have no dependencies.
        Hide
        bodewig Stefan Bodewig added a comment -

        I didn't know it was possible to add a dependencies list for a target that we don't provide assemblies for.

        What you suggest in the NuGet issue would have warned me but not really solve the underlying problem that NuGet considers .NET Standard 1.3 closer to 4.6 than 4.5, does it? Does it select the 4.5 assemblies rather than the .NET Standard ones, at least?

        Show
        bodewig Stefan Bodewig added a comment - I didn't know it was possible to add a dependencies list for a target that we don't provide assemblies for. What you suggest in the NuGet issue would have warned me but not really solve the underlying problem that NuGet considers .NET Standard 1.3 closer to 4.6 than 4.5, does it? Does it select the 4.5 assemblies rather than the .NET Standard ones, at least?

          People

          • Assignee:
            Unassigned
            Reporter:
            simoncropp Simon Cropp
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 10m
              10m
              Remaining:
              Remaining Estimate - 10m
              10m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development