Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.12
    • Fix Version/s: 1.2.13
    • Component/s: Appenders
    • Labels:
      None
    • Environment:
      Windows 7, net 4

      Description

      After update to log4net 1.2.12 email encoding changed and my mail client
      fail to render unicode symbols.
      I think changes made for issue https://issues.apache.org/jira/browse/LOG4NET-354 brake encoding in SmtpAppender
      log4net 1.2.10 use utf-8 encoding by default, below headers from email
      Content-Type: text/plain; charset=utf-8
      Content-Transfer-Encoding: base64
      after update on log4net 1.2.12 email encoding koi8-r
      Content-Type: text/plain; charset=koi8-r
      Content-Transfer-Encoding: quoted-printable
      I think change default encoding from utf-8 is pretty strange.

      Proposed fix:
      Do not use Encoding.Default, let SubjectEncoding and BodyEncoding by default be null, on email send set encoding only if field not null.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        1h 27m 1 Dominik Psenner 13/Nov/13 07:20
        In Progress In Progress Resolved Resolved
        4m 7s 1 Dominik Psenner 13/Nov/13 07:24
        Dominik Psenner made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Dominik Psenner added a comment -

        Fixed as of revision: 1541408

        Show
        Dominik Psenner added a comment - Fixed as of revision: 1541408
        Dominik Psenner made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Dominik Psenner made changes -
        Assignee Dominik Psenner [ nachbarslumpi ]
        Dominik Psenner made changes -
        Field Original Value New Value
        Fix Version/s 1.2.13 [ 12325554 ]
        Hide
        Dominik Psenner added a comment -

        You're right. According to http://msdn.microsoft.com/en-us/library/system.text.encoding.default(v=vs.110).aspx Encoding.UTF8 might be a better default encoding. I'm changing that right away and voting now that it should be shipped along with 1.2.13.

        Show
        Dominik Psenner added a comment - You're right. According to http://msdn.microsoft.com/en-us/library/system.text.encoding.default(v=vs.110).aspx Encoding.UTF8 might be a better default encoding. I'm changing that right away and voting now that it should be shipped along with 1.2.13.
        Roman Kvasov created issue -

          People

          • Assignee:
            Dominik Psenner
            Reporter:
            Roman Kvasov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development