[LOG4J2-834] ThrowableProxy throws NoClassDefFoundError

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.2
• Assignee: Gary D. Gregory
• Reporter: Nikita Koval
• Created: 17/Sep/14 11:48
• Updated: 06/Apr/15 09:56
• Resolved: 01/Dec/14 05:27

Description

In method loadClass we expect ClassNotFoundException. But if class comes from another java machine we can get NoClassDefFoundError.

Possible fix:

private Class<?> loadClass(final ClassLoader lastLoader, final String className) {
       // XXX: this is overly complicated
       Class<?> clazz;
       if (lastLoader != null) {
           try {
               clazz = Loader.initializeClass(className, lastLoader);
               if (clazz != null) {
                   return clazz;
               }
           } catch (final Throwable ignore) {
               // Ignore exception.
           }
       }
       try {
           clazz = Loader.loadClass(className);
       } catch (final ClassNotFoundException | LinkageError ignored) {
           try {
               clazz = Loader.initializeClass(className, this.getClass().getClassLoader());
           } catch (final ClassNotFoundException | LinkageError ignore) {
               return null;
           }
       }
       return clazz;
   }

Issue Links

• relates to: LOG4J2-832 ThrowableProxy fails if a class in logged stack trace throws java.lang.Error from initializer