Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-744

Avoid unnecessary Clock calls when TimestampMessage is logged

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.1
    • Component/s: None
    • Labels:
      None

      Description

      The TimestampMessage interface was introduced in LOG4J2-53 and revised for AsyncLogger in LOG4J2-455.

      I've observed that Clock.currentTimeMillis is still called which should not be necessary.

      I have two patches, one which adds JUnit tests that demonstrate the unnecessary Clock calls, and one which fixes the issue for both AsyncLogger and "traditional" configurations.

        Attachments

        1. ClockBenchmark.java
          13 kB
          Scott Harrington
        2. ClockBenchmark-jdk1.6.0_31.txt
          35 kB
          Scott Harrington
        3. ClockBenchmark-jdk1.7.0_45.txt
          35 kB
          Scott Harrington
        4. LOG4J2-744.patch
          3 kB
          Scott Harrington
        5. LOG4J2-744-test.patch
          13 kB
          Scott Harrington

          Issue Links

            Activity

              People

              • Assignee:
                remkop@yahoo.com Remko Popma
                Reporter:
                seh4nc Scott Harrington
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: