Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-705

Async logger loses thread context stack for events

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0-rc2
    • 2.0
    • Core
    • None

    Description

      I've enabled the async logger and created some log message with values in thread context stack. However, the logged message does not contain any of these items.

      Looking at the sources, it seems that AsyncLogger.logMessage() needs to clone the stack instead of using ThreadContext.getImmutableStack() (line 260). This is because getImmutableStack() method returns the same stack as original - getting the real one from thread local storage. So when passed to another thread (as async does), the same stack "looks" into different thread and returns empty list. It is even possible to break this "immutable" stack when you create your own appender and use ThreadContext.push() in append() method. This will affect the message being logged.

      Simple solution is to replace getImmutableStack() method in AsyncLogger.logMessage() (line 260) with ThreadContext.cloneStack(). But I'm not sure if this is the right way.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rpopma Remko Popma
            mfrydl Martin Frydl
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment