[LOG4J2-673] plugin preloading fails in shaded jar files

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Affects Version/s: 2.0-rc2, 2.1
• Fix Version/s: 3.0.0
• Component/s: Core
• Labels: annotations compiler plugins
• Assignee: Matt Sicker
• Reporter: Michael Semb Wever
• Created: 19/Jun/14 20:16
• Updated: 22/May/20 10:26

Description

Support for plugin preloading through the standard javax.annotation.processing tool was adding in LOG4J2-595

But the plugin processor always creates and stores the processed "Plugin" annotated classes into the same file. This works fine when the classpath consists of individual jar files, but fails when shaded jar files are used.

A tested fix exists at https://github.com/finn-no/logging-log4j2/tree/bugfix/LOG4J2-673
There's also a github pull request and a manual diff attached. (I can clean up anything not used afterwards)

The fix saves the dat file in a location under META-INF that matches the shared package all the processed plugins are found under.
The package attribute in the config file is then used so that multiple dat files can be loaded at runtime.
This means that the package attribute is no longer deprecated.

This has been tested against https://github.com/finn-no/log4j2-logstash-jsonevent-layout

Issue Links

• relates to: LOG4J2-2621 Create log4j-plugins module and use ServiceLoader to load plugins