Log4j 2
  1. Log4j 2
  2. LOG4J2-657

AbstractDatabaseManager doesn't close connection on writeInternal error

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-rc2
    • Fix Version/s: 2.0.1
    • Component/s: Appenders
    • Labels:
      None

      Description

      When using the JDBCAppender: if the AbstractDatabaseManager.writeInternal() method fails (e.g. value to large for column size, or any other database error) the database connection is not closed.

      I've attached a proposed patch to fix this - please take a look and see if it makes sense to handle write failures this way.

      1. finally.patch
        1 kB
        Stefan Wehner

        Activity

        Stefan Wehner created issue -
        Stefan Wehner made changes -
        Field Original Value New Value
        Attachment finally.patch [ 12647372 ]
        Stefan Wehner made changes -
        Description When the writeInternal method fails (e.g. value to large for column size, or any other database error) the connection is not closed.

        I've attached a proposed patch to fix this - please take a look and see if it makes sense to handle write failures this way.
        When using the JDBCAppender: if the AbstractDatabaseManager.writeInternal() method fails (e.g. value to large for column size, or any other database error) the database connection is not closed.

        I've attached a proposed patch to fix this - please take a look and see if it makes sense to handle write failures this way.
        Hide
        Stefan Wehner added a comment -

        Any news on this?

        Show
        Stefan Wehner added a comment - Any news on this?
        Remko Popma made changes -
        Assignee Remko Popma [ remkop@yahoo.com ]
        Remko Popma made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Remko Popma added a comment -

        Thanks for the patch!

        Fixed in revision 1610682.
        Please verify and close.

        Show
        Remko Popma added a comment - Thanks for the patch! Fixed in revision 1610682. Please verify and close.
        Remko Popma made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 2.1 [ 12326822 ]
        Resolution Fixed [ 1 ]
        Remko Popma made changes -
        Fix Version/s 2.0.1 [ 12327381 ]
        Fix Version/s 2.1 [ 12326822 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        46d 22h 56m 1 Remko Popma 15/Jul/14 14:15
        In Progress In Progress Resolved Resolved
        2m 27s 1 Remko Popma 15/Jul/14 14:17

          People

          • Assignee:
            Remko Popma
            Reporter:
            Stefan Wehner
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development