Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-2973

Rename EventTemplateAdditionalField#type (conflicting with properties file parser) to "format"

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.14.0
    • Fix Version/s: 3.0.0, 2.14.1
    • Component/s: JsonTemplateLayout
    • Labels:
      None

      Description

      In a GitHub discussion, it has been shared that the injection of plug-in builder attributes of type array from properties files is not working. But... It actually works! The reason it doesn't work for injecting a field of type EventTemplateAdditionalField[] is the EventTemplateAdditionalField#type field whose name conflicts with the type keyword property file loader uses to determine the type of an element.

      This PR renames EventTemplateAdditionalField#type to format. While this is not a backward compatible change, injection of JSON template layout eventTemplateAdditionalFields has already been broken in release 2.14.0 and the introduced fix has already broken the backward compatibility. See LOG4J2-2961 for details. Hence, it should be okay.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vy Volkan Yazici
                Reporter:
                vy Volkan Yazici
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: