[LOG4J2-2813] Questionable code in AbstractStringLayout.serializeToBytes()

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.13.1
• Fix Version/s: 2.13.2
• Component/s: Layouts
• Assignee: Unassigned
• Reporter: Keith D Gregory
• Created: 04/Apr/20 12:08
• Updated: 17/Apr/20 22:57
• Resolved: 17/Apr/20 22:57

Description

Source from current master:

protected byte[] serializeToBytes(final Serializer serializer, final byte[] defaultValue) {
    final String serializable = serializeToString(serializer);
    if (serializer == null) {
        return defaultValue;
    }
    return StringEncoder.toBytes(serializable, getCharset());
}

I believe the test should be on "serializable" not "serializer".