[LOG4J2-273] Wasted work in XMLLayout.toSerializable()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0-beta6
• Fix Version/s: 2.0-beta8
• Component/s: Layouts
• Labels: patch perfomance

Environment

any

• Assignee: Gary D. Gregory
• Reporter: Adrian Nistor
• Created: 06/Jun/13 17:23
• Updated: 07/Jun/13 15:36
• Resolved: 07/Jun/13 15:36

Description

The problem appears in Log4j 2.0-beta6 and in revision 1490297. I
attached a one-line patch that fixes it.

In method "XMLLayout.toSerializable", the loop over
"formats" should break immediately after
"xmlSupported" is set to "true". All the iterations after
"xmlSupported" is set to "true" do not perform any useful work,
at best they just set "xmlSupported" again to "true".