Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-2634

AsyncLogger method bytecode should be reduced to 35 bytes for fast inlining

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.11.2
    • Fix Version/s: 2.12.0
    • Component/s: None
    • Labels:
      None

      Description

      Large methods:

      AsyncLogger.logMessage conditional behavior produces a large method, this can be broken into an abstraction which two implementations.

       

      AsyncLogger.actualAsyncLog can be inlined in cases where Properties are not set

      RingBufferLogEventHandler.onEvent callback notification makes sense in a separate method so that both are below 35b

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ckozak Carter Kozak
                Reporter:
                ckozak Carter Kozak
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m