Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-2634

AsyncLogger method bytecode should be reduced to 35 bytes for fast inlining

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.11.2
    • 2.12.0
    • None
    • None

    Description

      Large methods:

      AsyncLogger.logMessage conditional behavior produces a large method, this can be broken into an abstraction which two implementations.

       

      AsyncLogger.actualAsyncLog can be inlined in cases where Properties are not set

      RingBufferLogEventHandler.onEvent callback notification makes sense in a separate method so that both are below 35b

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ckozak Carter Kozak
            ckozak Carter Kozak
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m

                Slack

                  Issue deployment