[LOG4J2-248] Log4jWebInitializerImpl: Use Thread instead of Class for fallback classloader

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0-beta5
• Fix Version/s: 2.6
• Assignee: Matt Sicker
• Reporter: Tim Tucker
• Created: 09/May/13 22:58
• Updated: 09/Mar/17 09:16
• Resolved: 08/Mar/16 20:40

Description

I was experimenting with creating my own context listener based on Log4jContextListener and noticed that the call in getClassLoader to get the class's classloader was triggering a PMD warning.

The rule's notes indicate that Thread.currentThread().getContextClassLoader() might return more reliable results than Object.class.getClassLoader().

The code in question is as follows:
try {
// if container is Servlet 3.0, use its getClassLoader method
return (ClassLoader)context.getClass().getMethod("getClassLoader").invoke(context);
} catch (Exception ignore) {
// otherwise, use this class's class loader
return Log4jContextListener.class.getClassLoader();
}

Issue Links

• breaks: LOG4J2-1841 Problems with consequences after LOG4J2-248