[LOG4J2-2428] Use the AuditExceptionHandler for validation exceptions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Log4j-Audit 1.0.0
• Fix Version/s: Log4j-Audit 1.0.1
• Component/s: Log4j-Audit
• Assignee: Unassigned
• Reporter: Andrei Ivanov
• Created: 03/Sep/18 12:39
• Updated: 04/Nov/18 17:49
• Resolved: 04/Nov/18 06:53

Description

Since I don't want the audit exceptions to stop the execution of the application code, I've tried defining a simple AuditExceptionHandler that just logs the exceptions.

The AuditExceptionHandler is invoked currently only to handle exceptions caused by the logEvent method, but it would be nice to use it for the validation exceptions as well.

Otherwise my logging code looks like this:

try {
        logCashPaymentOut(result);
} catch (Exception e) {
        // log exception here
}

 private void logCashPaymentOut(SalesTransaction salesTransaction) {
         CashPaymentOut event = LogEventFactory.getEvent(CashPaymentOut.class);
        event.setSalesTransaction(salesTransaction.getUuid());
        event.setAmount(salesTransaction.getReturn().getAmount());
        event.setCurrency(salesTransaction.getReturn().getCurrency().name());
        event.setCurrency("Cash return");
        event.logEvent();
}

And I want to get rid of the try/catch blocks that are now needed because the setters can trigger exceptions too.

Issue Links

• links to: GitHub Pull Request #12