Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-beta5
    • Component/s: Core, Documentation
    • Labels:
      None

      Description

      Patch to follow soon.

        Issue Links

          Activity

          Hide
          Remko Popma added a comment -

          Please find attached file LOG4J2-208-merge-async-into-core.patch.

          This removes the log4j-async module and moves all its classes and resources into core.

          I moved the Fast*Appenders into the core.appenders package, and also moved the documentation subsection on these appenders from manual/async.xml to manual/appenders.xml.

          Also updated documentation.

          Show
          Remko Popma added a comment - Please find attached file LOG4J2-208 -merge-async-into-core.patch. This removes the log4j-async module and moves all its classes and resources into core. I moved the Fast*Appenders into the core.appenders package, and also moved the documentation subsection on these appenders from manual/async.xml to manual/appenders.xml. Also updated documentation.
          Hide
          Remko Popma added a comment -

          I forgot to add links to the Fast*Appender sections in the side menu of the appenders manual page.

          This is fixed in the new attachment LOG4J2-208-v2-merge-async-into-core.patch.

          I will remove the previous file LOG4J2-208-merge-async-into-core.patch to avoid confusion.

          Show
          Remko Popma added a comment - I forgot to add links to the Fast*Appender sections in the side menu of the appenders manual page. This is fixed in the new attachment LOG4J2-208 -v2-merge-async-into-core.patch. I will remove the previous file LOG4J2-208 -merge-async-into-core.patch to avoid confusion.
          Hide
          Remko Popma added a comment -

          Minor detail with attached patch: in core/src/site/xdoc/index.xml
          I added some of the optional dependencies but I just noticed I forgot to add
          <li>Windows color support requires Jansi.</li>

          Sorry, I cannot submit a patch from work. If possible could this be fixed manually after applying the patch? Thanks!

          Show
          Remko Popma added a comment - Minor detail with attached patch: in core/src/site/xdoc/index.xml I added some of the optional dependencies but I just noticed I forgot to add <li>Windows color support requires Jansi.</li> Sorry, I cannot submit a patch from work. If possible could this be fixed manually after applying the patch? Thanks!
          Hide
          Ralph Goers added a comment -

          Patch applied in revision 1469106. Please verify and close.

          Show
          Ralph Goers added a comment - Patch applied in revision 1469106. Please verify and close.
          Hide
          Remko Popma added a comment -

          Looks good. Thank you very much!

          Show
          Remko Popma added a comment - Looks good. Thank you very much!

            People

            • Assignee:
              Ralph Goers
              Reporter:
              Remko Popma
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development