Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-1991

Refactor SimpleMessage to use ternary statements where appropriate

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0
    • Component/s: API
    • Labels:
      None

      Description

      I have cleaned up and refactored a couple blocks of code to be more readable without changing fundamental mechanics. The changes make it easier to read and reduce 7 lines of code bloat.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kpm1985 opened a pull request:

          https://github.com/apache/logging-log4j2/pull/100

          LOG4J2-1991 - Refactor SimpleMessage to be concise and clear with the use of approp…

          …riate ternary statements. All test have been ran from the log4j2-api root and pass with build success as expected.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kpm1985/logging-log4j2 refactor

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/logging-log4j2/pull/100.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #100


          commit 75f0b6d1a76e0122aa8c451f3ecc07db0f068976
          Author: Kenneth McFarland <kennethpaulmcfarland@gmail.com>
          Date: 2017-07-27T05:01:13Z

          refactor SimpleMessage to be concise and clear with the use of appropriate ternary statements.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/100 LOG4J2-1991 - Refactor SimpleMessage to be concise and clear with the use of approp… …riate ternary statements. All test have been ran from the log4j2-api root and pass with build success as expected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kpm1985/logging-log4j2 refactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/logging-log4j2/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit 75f0b6d1a76e0122aa8c451f3ecc07db0f068976 Author: Kenneth McFarland <kennethpaulmcfarland@gmail.com> Date: 2017-07-27T05:01:13Z refactor SimpleMessage to be concise and clear with the use of appropriate ternary statements.
          Show
          kpm1985 kenneth mcfarland added a comment - Link to PR : https://github.com/apache/logging-log4j2/pull/100
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3ed637d29bf9a5c567120ccc5aad600206174ec8 in logging-log4j2's branch refs/heads/master from Kenneth McFarland
          [ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=3ed637d ]

          LOG4J2-1991 Refactor SimpleMessage to be concise and clear. Closes
          #100.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3ed637d29bf9a5c567120ccc5aad600206174ec8 in logging-log4j2's branch refs/heads/master from Kenneth McFarland [ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=3ed637d ] LOG4J2-1991 Refactor SimpleMessage to be concise and clear. Closes #100.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/logging-log4j2/pull/100

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/logging-log4j2/pull/100
          Hide
          garydgregory Gary Gregory added a comment -

          In git master, please verify and close. Thank you.

          Show
          garydgregory Gary Gregory added a comment - In git master, please verify and close. Thank you.

            People

            • Assignee:
              Unassigned
              Reporter:
              kpm1985 kenneth mcfarland
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 10m
                10m
                Remaining:
                Remaining Estimate - 10m
                10m
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development