Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-beta5
    • Component/s: None
    • Labels:
      None

      Description

      Created JIRA ticket for this so I can submit a patch:

      > Remko,
      >
      > I just noticed that the log4j-async project is creating log files in the root directory
      of the project. This is bad practice. Can you modify the tests so that all the log files are
      written under the target directory?
      >
      > Ralph

        Activity

        Remko Popma created issue -
        Hide
        Remko Popma added a comment -

        Please find attached file LOG4J2-195.patch.

        It contains fixed JUnit test and config xml resource files.

        Note that one of these tests, FastRollingFileAppenderRolloverTest, depends on LOG4J2-193.

        Show
        Remko Popma added a comment - Please find attached file LOG4J2-195 .patch. It contains fixed JUnit test and config xml resource files. Note that one of these tests, FastRollingFileAppenderRolloverTest, depends on LOG4J2-193 .
        Remko Popma made changes -
        Field Original Value New Value
        Attachment LOG4J2-195.patch [ 12576776 ]
        Hide
        Ralph Goers added a comment -

        I applied the patch in revision 1465483. However, I had to comment out 1 line in FastRollingFileAppenderRolloverTest as it is failing with the stack trace below. In addition all of the test classes and ClockFactory were missing Apache License headers so I added them. Finally, I noticed that when I generated the web site the async project has over 70 checkstyle errors.

        Running org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest
        Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.453 sec <<< FAILURE!
        testRollover(org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest) Time elapsed: 0.397 sec <<< FAILURE!
        java.lang.AssertionError: No more lines
        at org.junit.Assert.fail(Assert.java:91)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertNull(Assert.java:549)
        at org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest.testRollover(FastRollingFileAppenderRolloverTest.java:72)

        Show
        Ralph Goers added a comment - I applied the patch in revision 1465483. However, I had to comment out 1 line in FastRollingFileAppenderRolloverTest as it is failing with the stack trace below. In addition all of the test classes and ClockFactory were missing Apache License headers so I added them. Finally, I noticed that when I generated the web site the async project has over 70 checkstyle errors. Running org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.453 sec <<< FAILURE! testRollover(org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest) Time elapsed: 0.397 sec <<< FAILURE! java.lang.AssertionError: No more lines at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.junit.Assert.assertNull(Assert.java:549) at org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest.testRollover(FastRollingFileAppenderRolloverTest.java:72)
        Hide
        Ralph Goers added a comment -

        Rats. I didn't see the note on the dependency on LOG4J2-193

        Show
        Ralph Goers added a comment - Rats. I didn't see the note on the dependency on LOG4J2-193
        Hide
        Remko Popma added a comment -

        It would be great if you could look at that one too...
        Apologies for the missing headers and I'll look at the checksite output.

        Show
        Remko Popma added a comment - It would be great if you could look at that one too... Apologies for the missing headers and I'll look at the checksite output.
        Hide
        Ralph Goers added a comment -

        After applying the patch for LOG4J2-193 the unit test no longer fails.

        Show
        Ralph Goers added a comment - After applying the patch for LOG4J2-193 the unit test no longer fails.
        Ralph Goers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Ralph Goers [ ralph.goers@dslextreme.com ]
        Fix Version/s 2.0-beta5 [ 12323970 ]
        Resolution Fixed [ 1 ]
        Hide
        Remko Popma added a comment -

        Confirmed. Thanks!

        Show
        Remko Popma added a comment - Confirmed. Thanks!
        Remko Popma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4d 9h 51m 1 Ralph Goers 08/Apr/13 00:00
        Resolved Resolved Closed Closed
        8h 22m 1 Remko Popma 08/Apr/13 08:23

          People

          • Assignee:
            Ralph Goers
            Reporter:
            Remko Popma
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development