Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta5
    • Fix Version/s: 2.0-beta5
    • Component/s: None
    • Labels:

      Description

      As discussed on the log4j-dev mailing list, I have created a new component for Log4j 2: log4j-taglib.

      More details on discussion is here: http://markmail.org/thread/gbwjsthvu7qsh5zo

      Will attach patch in comment.

      1. Added_Log4j_Tab_Library.patch
        98 kB
        Nick Williams
      2. log4j-taglib-build-install.patch
        0.8 kB
        Nick Williams
      3. log4j-taglib-tests-fixes.patch
        90 kB
        Nick Williams

        Activity

        Nick Williams created issue -
        Hide
        Nick Williams added a comment -

        Patch attached that does the following, per discussions on mailing list:

        • Adds log4j-taglib component/artifact
        • Changes Servlet dependencies across Log4j2 project from 2.4 (Java EE 4) to 2.5 (Java EE 5)
        • Updates parent site to link to log4j-taglib site on sidebar

        Also, I noticed that there was a dependency divergence (some components used junit 4.3.1, most used junit 4.7). I corrected that.

        Finally:

        • All unit tests pass.
        • Findbugs found no bugs in my code
        • Checkstyle found no problems in my code
        • Used maven-taglib-plugin to generate taglib documentation and validation reports for reports tab on sidebar
        Show
        Nick Williams added a comment - Patch attached that does the following, per discussions on mailing list: Adds log4j-taglib component/artifact Changes Servlet dependencies across Log4j2 project from 2.4 (Java EE 4) to 2.5 (Java EE 5) Updates parent site to link to log4j-taglib site on sidebar Also, I noticed that there was a dependency divergence (some components used junit 4.3.1, most used junit 4.7). I corrected that. Finally: All unit tests pass. Findbugs found no bugs in my code Checkstyle found no problems in my code Used maven-taglib-plugin to generate taglib documentation and validation reports for reports tab on sidebar
        Nick Williams made changes -
        Field Original Value New Value
        Attachment Added_Log4j_Tab_Library.patch [ 12575955 ]
        Hide
        Nick Williams added a comment - - edited

        Lol. Please forgive the misspelling in the attachment file name...

        Show
        Nick Williams added a comment - - edited Lol. Please forgive the misspelling in the attachment file name...
        Hide
        Ralph Goers added a comment -

        I went to apply the patch but had a few problems with site.xml, xdocs/index.xml and package-info.java. It looks like these were diffs from the web subproject? I fixed that but then noticed that you have included @author tags. The ASF board has specifically told projects not to use them so we do not include them in Log4j, but I do not want to remove them without your approval of that. Finally, you said that all the unit tests pass but I'm not seeing any in the taglib project. Am I missing something?

        Show
        Ralph Goers added a comment - I went to apply the patch but had a few problems with site.xml, xdocs/index.xml and package-info.java. It looks like these were diffs from the web subproject? I fixed that but then noticed that you have included @author tags. The ASF board has specifically told projects not to use them so we do not include them in Log4j, but I do not want to remove them without your approval of that. Finally, you said that all the unit tests pass but I'm not seeing any in the taglib project. Am I missing something?
        Hide
        Nick Williams added a comment -
        • I don't know why `svn diff` did that. I copied these three files from the web subproject as a starting point. `svn diff` set them up as diffs "copied from" the web subproject instead of files "added." Sorry about this. I don't know how to make SVN not do this.
        • I did not know about the @author tags. My apologies. Feel free to remove them or, if necessary, I can remove them and re-submit the patch. Whichever is easier/quicker.
        • All of the unit tests for the rest of the project (API, core, web, etc.) pass. I am working on unit tests for the taglib subproject, but wanted to get this submitted so that people could start hammering on it, in case I didn't finish unit tests before beta5 was released.
        Show
        Nick Williams added a comment - I don't know why `svn diff` did that. I copied these three files from the web subproject as a starting point. `svn diff` set them up as diffs "copied from" the web subproject instead of files "added." Sorry about this. I don't know how to make SVN not do this. I did not know about the @author tags. My apologies. Feel free to remove them or, if necessary, I can remove them and re-submit the patch. Whichever is easier/quicker. All of the unit tests for the rest of the project (API, core, web, etc.) pass. I am working on unit tests for the taglib subproject, but wanted to get this submitted so that people could start hammering on it, in case I didn't finish unit tests before beta5 was released.
        Hide
        Ralph Goers added a comment -

        OK. I will remove the author tags.

        Show
        Ralph Goers added a comment - OK. I will remove the author tags.
        Hide
        Ralph Goers added a comment -

        Patch applied in revision 1465533.

        Show
        Ralph Goers added a comment - Patch applied in revision 1465533.
        Ralph Goers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Ralph Goers [ ralph.goers@dslextreme.com ]
        Resolution Fixed [ 1 ]
        Hide
        Nick Williams added a comment -

        Patch attached that updates the "Build & Install" page in the main site to include information about the log4j-taglib Maven artifact.

        Show
        Nick Williams added a comment - Patch attached that updates the "Build & Install" page in the main site to include information about the log4j-taglib Maven artifact.
        Nick Williams made changes -
        Attachment log4j-taglib-build-install.patch [ 12578987 ]
        Hide
        Nick Williams added a comment -

        Patch attached that: adds 78 unit tests!; fixes a bug; resolves some compiler, FindBugs, and CheckStyle warnings; and resolves a potential ClassLoader (memory) leak.

        Show
        Nick Williams added a comment - Patch attached that: adds 78 unit tests!; fixes a bug; resolves some compiler, FindBugs, and CheckStyle warnings; and resolves a potential ClassLoader (memory) leak.
        Nick Williams made changes -
        Attachment log4j-taglib-tests-fixes.patch [ 12579086 ]
        Nick Williams made changes -
        Attachment log4j-taglib-tests-fixes.patch [ 12579086 ]
        Hide
        Nick Williams added a comment -

        Updated log4j-taglib-tests-fixes.patch now that LOG4J2-211 has been fixed. Note that there are two patches that still need to be applied for this issue: log4j-taglib-build-install.patch and log4j-taglib-tests-fixes.patch.

        Show
        Nick Williams added a comment - Updated log4j-taglib-tests-fixes.patch now that LOG4J2-211 has been fixed. Note that there are two patches that still need to be applied for this issue: log4j-taglib-build-install.patch and log4j-taglib-tests-fixes.patch.
        Nick Williams made changes -
        Attachment log4j-taglib-tests-fixes.patch [ 12579566 ]
        Hide
        Ralph Goers added a comment -

        The latest patches have been installed in revision 1470034. Please verify and close.

        Show
        Ralph Goers added a comment - The latest patches have been installed in revision 1470034. Please verify and close.
        Hide
        Nick Williams added a comment -

        Excellent! The tag library appears to be complete. Certainly bugs will likely be identified and I will help deal with those as they come up. This new feature issue is closed.

        Show
        Nick Williams added a comment - Excellent! The tag library appears to be complete. Certainly bugs will likely be identified and I will help deal with those as they come up. This new feature issue is closed.
        Nick Williams made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ralph Goers
            Reporter:
            Nick Williams
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 48h
              48h
              Remaining:
              Remaining Estimate - 48h
              48h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development