Uploaded image for project: 'Log4j 2'
  1. Log4j 2
  2. LOG4J2-1603

Redo hashCode() and equals() methods in org.apache.logging.log4j.core.net.ssl classes.

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.6.2
    • Fix Version/s: None
    • Component/s: Core
    • Labels:
      None

      Description

      We have a few FindBugs warnings about hashCode() and equals(Object) methods in the package org.apache.logging.log4j.core.net.ssl classes.

      The first problem is that not all classes implement these method where some of the code expects it to like an equals() method calling another equals() method but there is not one and the behavior of Object.equals() kicks in.

      This change make it obvious where there are still issues: the behavior described above will only happen when the code path ends up in a JRE class which itself depends on Object.equals(), so you still get a FindBugs warning about that but it is no longer a warning about a class in our code. We can revisit how to best implement equals() for those classes later.

      It is possible that the warning is a false positive since the JRE could be using a subclass of the class FindBugs complains about.

        Attachments

          Activity

            People

            • Assignee:
              garydgregory Gary Gregory
              Reporter:
              garydgregory Gary Gregory
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: