Log4j 2
  1. Log4j 2
  2. LOG4J2-152

NullPointerException in (...)appender.rolling.helper.FileRenameAction if filePattern does not contain a parent directory

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta3
    • Fix Version/s: 2.0-beta4
    • Component/s: Appenders
    • Labels:
      None

      Description

      ERROR StatusLogger Error in synchronous task java.lang.NullPointerException
      at org.apache.logging.log4j.core.appender.rolling.helper.FileRenameAction.execute(FileRenameAction.java:85)
      at org.apache.logging.log4j.core.appender.rolling.helper.FileRenameAction.execute(FileRenameAction.java:71)
      at org.apache.logging.log4j.core.appender.rolling.RollingFileManager.rollover(RollingFileManager.java:140)
      at org.apache.logging.log4j.core.appender.rolling.RollingFileManager.checkRollover(RollingFileManager.java:97)
      at atlas.infra.log.RollingRandomAccessFileAppender.append(RollingRandomAccessFileAppender.java:52)
      at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:98)
      at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:335)
      at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:316)
      at org.apache.logging.log4j.core.Logger$PrivateConfig.logEvent(Logger.java:304)

      To reproduce, in log4j2.xml, specify a filePattern without a parent directory:
      <appenders>
      <RollingFile name="RollingFile" fileName="logs/app.log"
      filePattern="fileWithoutParentDir-%d

      {MM-dd-yyyy}

      -%i.log.gz">

      To fix, change org.apache.logging.log4j.core.appender.rolling.helper.FileRenameAction#execute(File, File, boolean) (line 85): add null check:

      if (parent != null && !parent.exists()) { // parent is null if not specified in filePattern

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Ralph Goers
            Reporter:
            Remko Popma
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development