[LOG4J2-152] NullPointerException in (...)appender.rolling.helper.FileRenameAction if filePattern does not contain a parent directory

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0-beta3
• Fix Version/s: 2.0-beta4
• Component/s: Appenders
• Assignee: Ralph Goers
• Reporter: Remko Popma
• Created: 15/Jan/13 04:08
• Updated: 11/Feb/13 06:22
• Resolved: 18/Jan/13 07:07

Description

ERROR StatusLogger Error in synchronous task java.lang.NullPointerException
at org.apache.logging.log4j.core.appender.rolling.helper.FileRenameAction.execute(FileRenameAction.java:85)
at org.apache.logging.log4j.core.appender.rolling.helper.FileRenameAction.execute(FileRenameAction.java:71)
at org.apache.logging.log4j.core.appender.rolling.RollingFileManager.rollover(RollingFileManager.java:140)
at org.apache.logging.log4j.core.appender.rolling.RollingFileManager.checkRollover(RollingFileManager.java:97)
at atlas.infra.log.RollingRandomAccessFileAppender.append(RollingRandomAccessFileAppender.java:52)
at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:98)
at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:335)
at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:316)
at org.apache.logging.log4j.core.Logger$PrivateConfig.logEvent(Logger.java:304)

To reproduce, in log4j2.xml, specify a filePattern without a parent directory:
<appenders>
<RollingFile name="RollingFile" fileName="logs/app.log"
filePattern="fileWithoutParentDir-%d

{MM-dd-yyyy}

-%i.log.gz">

To fix, change org.apache.logging.log4j.core.appender.rolling.helper.FileRenameAction#execute(File, File, boolean) (line 85): add null check:

if (parent != null && !parent.exists()) { // parent is null if not specified in filePattern