Log4j 2
  1. Log4j 2
  2. LOG4J2-129

RoutingAppender dynamic appender creation only creates 1

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta3
    • Fix Version/s: 2.0-beta4
    • Component/s: Appenders
    • Labels:
      None

      Description

      I was looking through the new appenders and found RoutingAppender which intrigued me

      http://logging.apache.org/log4j/2.x/manual/appenders.html#RoutingAppender

      From the documentation it seems that the RoutingAppender would create a new appender dynamically every time the key didn't match an existing appender name. However when testing this I find it only creates the first dynamically and then reuses that one as it is set to default. That doesn't seem what I would expect. My example code is as the following:

      public class TestRouting {
          public static void main(String[] args) {
              ThreadContext.put("filename", "foo.bar");
              _logger.info("TEST");
              ThreadContext.put("filename", "foo.bar2");
              _logger.info("TEST2");
              ThreadContext.remove("filename");
          }
      
          private final static Logger _logger = LogManager.getLogger(TestRouting.class);
      }
      

      Here is the log4j2 xml file it picks up.

      <?xml version="1.0" encoding="UTF-8"?>
      <configuration>
        <appenders>
          <Console name="Console" target="SYSTEM_OUT">
            <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
          </Console>
        
          <Routing name="RoutingAppender">
            <Routes pattern="${ctx:filename}">
              <Route>
                <RollingFile name="Rolling-${ctx:filename}" fileName="${ctx:filename}"
                             filePattern="${ctx:filename}.%i.log.gz">
                  <PatternLayout>
                    <pattern>%d %p %C{1.} [%t] %m%n</pattern>
                  </PatternLayout>
                  <SizeBasedTriggeringPolicy size="500" />
                </RollingFile>
              </Route>
            
              <!-- By having this set to ${ctx:filename} it will match when filename
                   is not set in the context -->
              <Route ref="Console" key="${ctx:filename}"/>
            
            </Routes>
          </Routing>
        </appenders>
          
        <loggers>
          <root level="info">
            <appender-ref ref="RoutingAppender"/>
          </root>
        </loggers>
      </configuration>
      

      When I run the test though it only creates 1 file/appender with the name foo.bar and logs both messages to it. I would expect that it creates 2 files where each gets the different message.

      Is there something I am missing about this or is this the intended behavior?

      I have a change that gets it working, however part of it is hack and would need to be updated to the best alternative. Also I had to change BaseConfiguration slightly to make a defensive copy of the attributes. It seemed that was fine, otherwise the Route cannot be reused to make another appender if it blows away the attributes, don't know if that will affect other things though.

      1. patch
        6 kB
        William Burns
      2. LOG4J2-129-RoutingAppenderTest.patch
        1 kB
        Ingo Feltes
      3. LOG4J2-129-RoutingAppender.patch
        8 kB
        Ingo Feltes

        Activity

        William Burns created issue -
        William Burns made changes -
        Field Original Value New Value
        Attachment patch [ 12555388 ]
        Ingo Feltes made changes -
        Attachment LOG4J2-129-RoutingAppender.patch [ 12555489 ]
        Ralph Goers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Ralph Goers [ ralph.goers@dslextreme.com ]
        Fix Version/s 2.0-beta4 [ 12323477 ]
        Resolution Fixed [ 1 ]
        Ingo Feltes made changes -
        Attachment LOG4J2-129-RoutingAppenderTest.patch [ 12555668 ]

          People

          • Assignee:
            Ralph Goers
            Reporter:
            William Burns
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development