Log4j 2
  1. Log4j 2
  2. LOG4J2-127

Methods info, warn, error, fatal with marker and message do not pass the marker

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta3
    • Fix Version/s: 2.0-beta4
    • Component/s: API
    • Labels:
      None

      Description

      The follwing methods do not log the message, because the marker is not passed to isXxxEnabled:

      AbstractLogger.info(Marker, Message)
      AbstractLogger.warn(Marker, Message)
      AbstractLogger.error(Marker, Message)
      AbstractLogger.fatal(Marker, Message)

        Activity

        Ingo Feltes created issue -
        Ingo Feltes made changes -
        Field Original Value New Value
        Description The follwing methods do not pass the marker parameter:

        AstractLogger.info(Marker, Message)
        AstractLogger.warn(Marker, Message)
        AstractLogger.error(Marker, Message)
        AstractLogger.fatal(Marker, Message)
        The follwing methods do not pass the marker parameter:

        AbstractLogger.info(Marker, Message)
        AbstractLogger.warn(Marker, Message)
        AbstractLogger.error(Marker, Message)
        AbstractLogger.fatal(Marker, Message)
        Ingo Feltes made changes -
        Description The follwing methods do not pass the marker parameter:

        AbstractLogger.info(Marker, Message)
        AbstractLogger.warn(Marker, Message)
        AbstractLogger.error(Marker, Message)
        AbstractLogger.fatal(Marker, Message)
        The follwing methods do not log the message, because the marker is not passed to isXxxEnabled:

        AbstractLogger.info(Marker, Message)
        AbstractLogger.warn(Marker, Message)
        AbstractLogger.error(Marker, Message)
        AbstractLogger.fatal(Marker, Message)
        Hide
        Ralph Goers added a comment -

        The methods were fixed in revision 1412759. Please verify and close.

        Show
        Ralph Goers added a comment - The methods were fixed in revision 1412759. Please verify and close.
        Ralph Goers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Ralph Goers [ ralph.goers@dslextreme.com ]
        Fix Version/s 2.0-beta4 [ 12323477 ]
        Resolution Fixed [ 1 ]
        Hide
        Ingo Feltes added a comment -

        error(Marker, Message) and fatal(Marker, Message) still not working. Please find attached a patch (including tests).

        Show
        Ingo Feltes added a comment - error(Marker, Message) and fatal(Marker, Message) still not working. Please find attached a patch (including tests).
        Ingo Feltes made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Ingo Feltes added a comment -

        Patch for API.

        Show
        Ingo Feltes added a comment - Patch for API.
        Ingo Feltes made changes -
        Attachment AbstractLogger.patch [ 12555200 ]
        Christian Grobmeier made changes -
        Summary info, warn, error, fatal with marker and message do not pass the marker Methods info, warn, error, fatal with marker and message do not pass the marker
        Hide
        Gary Gregory added a comment -

        commit -m "<action issue="LOG4J2-127" dev="rgoers" type="fix">AbstractLogger methods were not passing Markers to the isEnabled methods.</action>..." C:/svn/org/apache/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java C:/svn/org/apache/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
        Sending C:/svn/org/apache/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
        Sending C:/svn/org/apache/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java
        Transmitting file data ...
        Committed revision 1414958.

        Show
        Gary Gregory added a comment - commit -m "<action issue=" LOG4J2-127 " dev="rgoers" type="fix">AbstractLogger methods were not passing Markers to the isEnabled methods.</action>..." C:/svn/org/apache/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java C:/svn/org/apache/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java Sending C:/svn/org/apache/log4j2/trunk/api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java Sending C:/svn/org/apache/log4j2/trunk/api/src/test/java/org/apache/logging/log4j/AbstractLoggerTest.java Transmitting file data ... Committed revision 1414958.
        Gary Gregory made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        18h 44m 1 Ralph Goers 23/Nov/12 05:44
        Resolved Resolved Reopened Reopened
        5d 12h 1m 1 Ingo Feltes 28/Nov/12 17:45
        Reopened Reopened Resolved Resolved
        7h 12m 1 Gary Gregory 29/Nov/12 00:58

          People

          • Assignee:
            Ralph Goers
            Reporter:
            Ingo Feltes
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development