Major Description
Under heavy traffic load several SYSLOG messages can be concatenated, which is not correct.
The problem is, several threads in AbstractOutputStreamAppender can reach in the next code write() before one thread reaches flush() (the readLock.lock() is not lock at all)
@Override
public void append(final LogEvent event) {
readLock.lock();
try {
final byte[] bytes = getLayout().toByteArray(event);
if (bytes.length > 0) {
manager.write(bytes);
if (this.immediateFlush || event.isEndOfBatch()) {
manager.flush();
}
}
} catch (final AppenderLoggingException ex) {
error("Unable to write to stream " + manager.getName() + " for appender " + getName());
throw ex;
} finally {
readLock.unlock();
}
}
In DatagramOutputStream all messages are cumulated in instance variable private byte[] data;
Synchronized methods don't help and in this case the synchronization in DatagramOutputStream is useless, as the correct synchronization should be provided in AbstractOutputStreamAppender.
