[LOG4J2-1048] FileConfigurationMonitor - High CPU usage

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Component/s: Configurators, Core
• Assignee: Remko Popma
• Reporter: Nikhil
• Created: 09/Jun/15 22:16
• Updated: 11/Jun/15 16:19
• Resolved: 10/Jun/15 15:33

Description

I am observing some high system CPU usage as a result of high number of calls to System.currentTimeMillis() in FileConfigurationMonitor.checkConfiguration() method.

The checkConfiguration() method is called as part of Logger's every log/logIfEnabled and isEnabled method, therefore getting called thousands of times in my application when under moderate load. Each one of these calls therefore results in calling System.currentTimeMillis().

The following code change, where the currentTimeMillis() is called only when required seemed to reduce the cpu load

final long current = System.currentTimeMillis();
if(((counter.incrementAndGet() & MASK) == 0) && (current >= nextCheck))

Fixed as

 final long current;
        if (((counter.incrementAndGet() & MASK) == 0) && ((current = System.currentTimeMillis()) >= nextCheck)) {

Issue Links

• is superceded by: LOG4J2-982 Use System.nanoTime() to measure time intervals