[LIBCLOUD-926] [BUG Azure_ARM] in ex_create_public_ip function among other

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Compute
• Labels: azurecompute-arm compute
• Flags: Important
• External issue URL: https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/azure_arm.py
• Assignee: Unassigned
• Reporter: Cristina Guerra
• Created: 20/Jun/17 14:56
• Updated: 27/Sep/17 04:30

Description

In the file libcloud/compute/drivers/azure_arm.py.

There are some functions as ex_create_public_ip function that it needs a location parameter, when this parameter is send, a error happen: "Location is required".
Looking at the code I found with the following:

       if location is None and self.default_location:
            location = self.default_location
        else:
            raise ValueError("location is required.")

This does not evaluate a possible parameter, only if the value is None.

I propose:

        if location is None and self.default_location:
            location = self.default_location
        elif location is not None:
            location = location
        else:
            raise ValueError("location is required.")

Issue Links

• links to: GitHub Pull Request #1051
• links to: GitHub Pull Request #1098