Anton Kozyrev added a comment - 28/Oct/16 14:00 done in private repo: https://github.com/lrvan/libcloud/commit/c53331f60094c8600e29b6e145cf3216abb218cf

Anton Kozyrev added a comment - 01/Nov/16 15:37 Tests: https://github.com/lrvan/libcloud/commit/fc883f8f451eb58df18354dbf4f0b2cef45a2fbe

ASF GitHub Bot added a comment - 01/Nov/16 15:47 GitHub user lrvan opened a pull request: https://github.com/apache/libcloud/pull/936 LIBCLOUD-869 Implement get methods for AWS ALB driver AWS ALB Driver - get methods. Description AWS has introduced new type of load balancer - Application Load Balancer (ALB). http://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/Welcome.html It's supported in APIv2 (2015-12-01) whereas current libcloud AWS load balancer driver implementation works with APIv1 (2012-06-01). API versions aren't compatible - it's impossible to operate with classic load balancer (ELB) using v2 API and vice versa. So separate driver for ALB needs to be implemented. This change implements Provider.ALB driver with basic read functionality provided by the following methods: list_balancers; get_balancer; balancer_list_members; ex_balancer_list_listeners. Status done, ready for review Checklist (tick everything that applies) [ ] [Code linting] ( http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide ) (required, can be done after the PR checks) [ ] Documentation [ ] [Tests] ( http://libcloud.readthedocs.org/en/latest/testing.html ) [ ] [ICLA] ( http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes ) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lrvan/libcloud LIBCLOUD-869 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/936.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #936 commit c53331f60094c8600e29b6e145cf3216abb218cf Author: Anton Kozyrev <anton.kozyrev@gmail.com> Date: 2016-10-28T13:58:58Z LIBCLOUD-869 - AWS ALB driver with basic get methods commit fc883f8f451eb58df18354dbf4f0b2cef45a2fbe Author: Anton Kozyrev <anton.kozyrev@gmail.com> Date: 2016-11-01T15:35:26Z LIBCLOUD-869 - AWS ALB driver tests for get methods

Anton Kozyrev added a comment - 01/Nov/16 15:49 PR: https://github.com/apache/libcloud/pull/936/

ASF GitHub Bot added a comment - 10/Nov/16 01:04 Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/936

Anton Kozyrev added a comment - 10/Nov/16 12:42 Merged to trunk.