Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-714

Traceback when simplejson < 2.1.0 is installed

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Linux

    • Flags:
      Patch

      Description

      When simplejson 2.0.9 (the version available in RHEL 6) is installed, the following traceback occurs when attempting to use libcloud:

      Traceback (most recent call last):
      File "/usr/lib/python2.6/site-packages/salt/loader.py", line 951, in _load_module
      ), fn_, fpath, desc)
      File "/usr/lib/python2.6/site-packages/salt/cloud/clouds/rackspace.py", line 46, in <module>
      from libcloud.compute.base import NodeState
      File "/usr/lib/python2.6/site-packages/libcloud/compute/base.py", line 32, in <module>
      from libcloud.pricing import get_size_price
      File "/usr/lib/python2.6/site-packages/libcloud/pricing.py", line 26, in <module>
      JSONDecodeError = json.JSONDecodeError
      AttributeError: 'module' object has no attribute 'JSONDecodeError'

      Upgrading to simplejson 2.1.0 or greater fixes this issue. Applying the following fix to libcloud should resolve the issue: http://www.fpaste.org/225608/49936143/

        Activity

        Hide
        kami Tomaz Muraus added a comment -

        The proposed fix looks good to me. Let's just add a comment to the code so it's clear why we are doing that.

        Show
        kami Tomaz Muraus added a comment - The proposed fix looks good to me. Let's just add a comment to the code so it's clear why we are doing that.
        Hide
        terminalmage Erik Johnson added a comment -

        It's been 3 1/2 months, what is holding this up?

        Show
        terminalmage Erik Johnson added a comment - It's been 3 1/2 months, what is holding this up?
        Hide
        kami Tomaz Muraus added a comment - - edited

        Nothing.

        I thought you are Eric Johnson (a different person) which has commit rights to the repository so I thought you will just go ahead and commit the fix yourself once you add the comment.

        I just noticed though that this obviously won't work since you are a different person. The name and him also working on GCE is what got me confused

        Please open a Github PR with a fix and I will have a look and merge it asap.

        Edit: Next time do ping us earlier so I / we can also recognize the confusion sooner

        Show
        kami Tomaz Muraus added a comment - - edited Nothing. I thought you are Eric Johnson (a different person) which has commit rights to the repository so I thought you will just go ahead and commit the fix yourself once you add the comment. I just noticed though that this obviously won't work since you are a different person. The name and him also working on GCE is what got me confused Please open a Github PR with a fix and I will have a look and merge it asap. Edit: Next time do ping us earlier so I / we can also recognize the confusion sooner
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user terminalmage opened a pull request:

        https://github.com/apache/libcloud/pull/577

        Fix traceback when simplejson < 2.1.0 is installed

        See https://issues.apache.org/jira/browse/LIBCLOUD-714.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/terminalmage/libcloud libcloud-714

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/577.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #577


        commit 186db780916c65b857cfd00d98394c4316d598d4
        Author: Erik Johnson <palehose@gmail.com>
        Date: 2015-09-11T13:53:58Z

        Fix traceback when simplejson < 2.1.0 is installed

        See https://issues.apache.org/jira/browse/LIBCLOUD-714.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user terminalmage opened a pull request: https://github.com/apache/libcloud/pull/577 Fix traceback when simplejson < 2.1.0 is installed See https://issues.apache.org/jira/browse/LIBCLOUD-714 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/terminalmage/libcloud libcloud-714 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/577.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #577 commit 186db780916c65b857cfd00d98394c4316d598d4 Author: Erik Johnson <palehose@gmail.com> Date: 2015-09-11T13:53:58Z Fix traceback when simplejson < 2.1.0 is installed See https://issues.apache.org/jira/browse/LIBCLOUD-714 .
        Hide
        terminalmage Erik Johnson added a comment -

        I've actually met Eric, he's good people.

        PR submitted, I didn't know you accepted pulls via GitHub or I would have done this a while ago. Now I know. _

        Show
        terminalmage Erik Johnson added a comment - I've actually met Eric, he's good people. PR submitted, I didn't know you accepted pulls via GitHub or I would have done this a while ago. Now I know. _
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1aaaef95745cebf66a26128f3e74c13fa7361a90 in libcloud's branch refs/heads/trunk from Erik Johnson
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=1aaaef9 ]

        Fix traceback when simplejson < 2.1.0 is installed

        See https://issues.apache.org/jira/browse/LIBCLOUD-714.

        Closes #577

        Signed-off-by: Tomaz Muraus <tomaz@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1aaaef95745cebf66a26128f3e74c13fa7361a90 in libcloud's branch refs/heads/trunk from Erik Johnson [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=1aaaef9 ] Fix traceback when simplejson < 2.1.0 is installed See https://issues.apache.org/jira/browse/LIBCLOUD-714 . Closes #577 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/libcloud/pull/577

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/577

          People

          • Assignee:
            Unassigned
            Reporter:
            terminalmage Erik Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development