Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-676

ex_describe_tags shows results for instances only

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Compute
    • Labels:
      None

      Description

      While AWS EC2 describe-tags API will return tags for any resource with tags, the libcloud ex_describe_tags() will not.

      Looking at the code, ex_describe_tags() calls ec2's DescribeTags with a filter of "'resource-type': 'instance'"

      I've looked through commits on ec2.py - I don't see a reason (historical or otherwise) for having ex_describe_tags not work on all ec2 resources?

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jlk opened a pull request:

        https://github.com/apache/libcloud/pull/482

        LIBCLOUD-676: Allow describing AMI tags

        Per the referenced Jira - I can't think of a reason for why ex_describe_tags() shouldn't be able to be used for other resources besides instances and storage, so removed the filter.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jlk/libcloud trunk

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/482.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #482


        commit aaa518aff4283d51c063316ee1c79d3c0b102432
        Author: John Kinsella <jlk@stratosec.co>
        Date: 2015-03-09T23:57:39Z

        LIBCLOUD-676: Allow describing AMI tags

        Removed filter that only allows returning tags for ec2 instances


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jlk opened a pull request: https://github.com/apache/libcloud/pull/482 LIBCLOUD-676 : Allow describing AMI tags Per the referenced Jira - I can't think of a reason for why ex_describe_tags() shouldn't be able to be used for other resources besides instances and storage, so removed the filter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jlk/libcloud trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #482 commit aaa518aff4283d51c063316ee1c79d3c0b102432 Author: John Kinsella <jlk@stratosec.co> Date: 2015-03-09T23:57:39Z LIBCLOUD-676 : Allow describing AMI tags Removed filter that only allows returning tags for ec2 instances
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f4a149ec6a8b7478fdef645627b1bb445d189469 in libcloud's branch refs/heads/trunk from John Kinsella
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=f4a149e ]

        LIBCLOUD-676: Allow describing AMI tags

        Removed filter that only allows returning tags for ec2 instances

        Closes #482

        Signed-off-by: Tomaz Muraus <tomaz@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit f4a149ec6a8b7478fdef645627b1bb445d189469 in libcloud's branch refs/heads/trunk from John Kinsella [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=f4a149e ] LIBCLOUD-676 : Allow describing AMI tags Removed filter that only allows returning tags for ec2 instances Closes #482 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/libcloud/pull/482

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/482

          People

          • Assignee:
            Unassigned
            Reporter:
            jlkinsel John Kinsella
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development