Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-664

EC2 driver breaks contract with base driver in `list_volume_snapshots`

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The base driver has the following definition for `list_volume_snapshots`:

      def list_volume_snapshots(self, volume):
              """
              List snapshots for a storage volume.
              
              :rtype: ``list`` of :class:`VolumeSnapshot`
              """
              raise NotImplementedError(
                  'list_volume_snapshots not implemented for this driver')
      

      This function is volume-centric and should return all snapshots for the given Volume.

      In contrast, EC2 has the following, which is snapshot-centric and returns only the given snapshot.

          def list_volume_snapshots(self, snapshot):
              return self.list_snapshots(snapshot)
      

      We should change this to both be volume-centric. In its current form, this function is identical to list_snapshots and thus redundant.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              henkslaaf Allard Hoeve
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: