Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-650

Route53 ex_create_multi_value_record only returns one record

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: DNS
    • Labels:

      Description

      Calling ex_create_multi_value_record on the Route53 driver only returns one Record object but it should return several values.

      On libcloud.dns.driver.route53.py lines 270-276:

              records = []
              for value in values:
                  record = Record(id=id, name=name, type=type, data=value, zone=zone,
                                  driver=self, extra=extra)
                  records.append(record)
      
              return record
      

      It should return records instead.

      Creating a PR for this on github and adding tests to check for correct return values as well.

      This issue was discovered by http://github.com/jvrplmlmn

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit eb36e62772de9d2becbd9a9013595c0f7f96ecd0 in libcloud's branch refs/heads/trunk from Itxaka Serrano
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=eb36e62 ]

        Fixes LIBCLOUD-650: ex_create_multi_value_record only returns one record (route53 driver), adds tests for that function.

        Signed-off-by: Tomaz Muraus <tomaz@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit eb36e62772de9d2becbd9a9013595c0f7f96ecd0 in libcloud's branch refs/heads/trunk from Itxaka Serrano [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=eb36e62 ] Fixes LIBCLOUD-650 : ex_create_multi_value_record only returns one record (route53 driver), adds tests for that function. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user Itxaka opened a pull request:

        https://github.com/apache/libcloud/pull/431

        LIBCLOUD-650: ex_create_multi_value_record only returns one record

        Fixes that bug and also adds tests for that function.

        Bug discovery and solution by @jvrplmlmn

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/Itxaka/libcloud LIBCLOUD-650

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/431.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #431


        commit 7eaaedd0c29270b8875381be64d772d6a60a5434
        Author: Itxaka Serrano <itxakaserrano@gmail.com>
        Date: 2015-01-10T10:23:34Z

        Fixes LIBCLOUD-650: ex_create_multi_value_record only returns one record
        (route53 driver), adds tests for that function.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user Itxaka opened a pull request: https://github.com/apache/libcloud/pull/431 LIBCLOUD-650 : ex_create_multi_value_record only returns one record Fixes that bug and also adds tests for that function. Bug discovery and solution by @jvrplmlmn You can merge this pull request into a Git repository by running: $ git pull https://github.com/Itxaka/libcloud LIBCLOUD-650 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/431.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #431 commit 7eaaedd0c29270b8875381be64d772d6a60a5434 Author: Itxaka Serrano <itxakaserrano@gmail.com> Date: 2015-01-10T10:23:34Z Fixes LIBCLOUD-650 : ex_create_multi_value_record only returns one record (route53 driver), adds tests for that function.

          People

          • Assignee:
            Unassigned
            Reporter:
            Itxaka Itxaka Serrano
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development