Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-593

CloudStack driver's create_node fails to join network_id when network_id is int

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0, 0.13.1, 0.13.2, 0.14.0-beta3, 0.13.3
    • Fix Version/s: None
    • Component/s: Compute
    • Labels:
      None

      Description

      CloudStack driver's create_node accept an argument "networks" it is used to specify networks the node will be connected to.

      networks is a list of CloudStackNetwork instances and their id is joined to construct a argument for CloudStack API's deployVirtualMachine in create_node. It is OK when network id is string but some implementation uses integer network id.

      When network id is integer, the code like following fails.

      networks = driver.ex_list_networks()
      node = driver.create_node(location, image, size, networks=networks)

      This patch convert network id into str explicitly before joining network ids.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user atsaki opened a pull request:

        https://github.com/apache/libcloud/pull/336

        LIBCLOUD-593 CloudStack driver's create_node fails to join network_id ...

        CloudStack driver's create_node accept an argument "networks" it is used to specify networks the node will be connected to.
        networks is a list of CloudStackNetwork instances and their id is joined to construct a argument for CloudStack API's deployVirtualMachine in create_node. It is OK when network id is string but some implementation uses integer network id.
        When network id is integer, the code like following fails.
        networks = driver.ex_list_networks()
        node = driver.create_node(location, image, size, networks=networks)
        This patch convert network id into str explicitly before joining network ids.

        https://issues.apache.org/jira/browse/LIBCLOUD-593

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/atsaki/libcloud 593-convert_network_id_to_str

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/libcloud/pull/336.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #336


        commit a0ad7845a7cd5b380af5a707b69de1b042bedaf9
        Author: Atsushi Sasaki <atsaki01@gmail.com>
        Date: 2014-07-05T10:55:22Z

        LIBCLOUD-593 CloudStack driver's create_node fails to join network_id when network_id is int


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user atsaki opened a pull request: https://github.com/apache/libcloud/pull/336 LIBCLOUD-593 CloudStack driver's create_node fails to join network_id ... CloudStack driver's create_node accept an argument "networks" it is used to specify networks the node will be connected to. networks is a list of CloudStackNetwork instances and their id is joined to construct a argument for CloudStack API's deployVirtualMachine in create_node. It is OK when network id is string but some implementation uses integer network id. When network id is integer, the code like following fails. networks = driver.ex_list_networks() node = driver.create_node(location, image, size, networks=networks) This patch convert network id into str explicitly before joining network ids. https://issues.apache.org/jira/browse/LIBCLOUD-593 You can merge this pull request into a Git repository by running: $ git pull https://github.com/atsaki/libcloud 593-convert_network_id_to_str Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit a0ad7845a7cd5b380af5a707b69de1b042bedaf9 Author: Atsushi Sasaki <atsaki01@gmail.com> Date: 2014-07-05T10:55:22Z LIBCLOUD-593 CloudStack driver's create_node fails to join network_id when network_id is int
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 784e7beb05df95fe6d85c9a0720c8234670229d4 in libcloud's branch refs/heads/trunk from Atsushi Sasaki
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=784e7be ]

        LIBCLOUD-593: CloudStack driver's create_node fails to join network_id when network_id is int

        Closes #336

        Signed-off-by: Sebastien Goasguen <runseb@gmail.com>

        Show
        jira-bot ASF subversion and git services added a comment - Commit 784e7beb05df95fe6d85c9a0720c8234670229d4 in libcloud's branch refs/heads/trunk from Atsushi Sasaki [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=784e7be ] LIBCLOUD-593 : CloudStack driver's create_node fails to join network_id when network_id is int Closes #336 Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/libcloud/pull/336

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/336
        Hide
        sebgoa sebastien goasguen added a comment -

        GitHub patch applied to trunk, I am closing this issue.

        thanks for your patch.

        Show
        sebgoa sebastien goasguen added a comment - GitHub patch applied to trunk, I am closing this issue. thanks for your patch.

          People

          • Assignee:
            Unassigned
            Reporter:
            atsaki Atsushi Sasaki
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development