Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-475

Different name for key_pair in node in Ec2 and Openstack driver

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      I detect in source code different name for keypair name in extra parameters for node. In Amazon and Cloudstack it called 'keyname' but in Openstack driver it - 'key_name'.
      I can rename it on Openstack or Ec2/Cloudstack if You say what variant I must use.

        Activity

        Hide
        gigimon Oleg Suharev added a comment -

        Ok, will know

        Show
        gigimon Oleg Suharev added a comment - Ok, will know
        Hide
        kami Tomaz Muraus added a comment -

        The patch contained a lint issue which I have fixed and merged patch into trunk.

        Next time, please make sure to run tox -e lint before submitting a final patch.

        Thanks!

        Show
        kami Tomaz Muraus added a comment - The patch contained a lint issue which I have fixed and merged patch into trunk. Next time, please make sure to run tox -e lint before submitting a final patch. Thanks!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1ab9da5c87caddd8b5e0b5ff13cb39d3ded2693f in branch refs/heads/trunk from Oleg Suharev
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=1ab9da5 ]

        LIBCLOUD-475 fix key_name in Ec2 and Cloudstack drivers

        Signed-off-by: Tomaz Muraus <tomaz@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1ab9da5c87caddd8b5e0b5ff13cb39d3ded2693f in branch refs/heads/trunk from Oleg Suharev [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=1ab9da5 ] LIBCLOUD-475 fix key_name in Ec2 and Cloudstack drivers Signed-off-by: Tomaz Muraus <tomaz@apache.org>
        Hide
        gigimon Oleg Suharev added a comment -

        Sorry, please try now.

        Show
        gigimon Oleg Suharev added a comment - Sorry, please try now.
        Hide
        kami Tomaz Muraus added a comment -

        Can you please also sync your branch with latest trunk and re-generate the patch?

        I have troubles applying it cleanly:

        Applying: LIBCLOUD-475 fix key_name in ec2 and cloudstack
        error: patch failed: libcloud/compute/drivers/cloudstack.py:1497
        error: libcloud/compute/drivers/cloudstack.py: patch does not apply
        error: patch failed: libcloud/test/compute/test_cloudstack.py:248
        error: libcloud/test/compute/test_cloudstack.py: patch does not apply
        Patch failed at 0001 LIBCLOUD-475 fix key_name in ec2 and cloudstack
        The copy of the patch that failed is found in:
        
        Show
        kami Tomaz Muraus added a comment - Can you please also sync your branch with latest trunk and re-generate the patch? I have troubles applying it cleanly: Applying: LIBCLOUD-475 fix key_name in ec2 and cloudstack error: patch failed: libcloud/compute/drivers/cloudstack.py:1497 error: libcloud/compute/drivers/cloudstack.py: patch does not apply error: patch failed: libcloud/test/compute/test_cloudstack.py:248 error: libcloud/test/compute/test_cloudstack.py: patch does not apply Patch failed at 0001 LIBCLOUD-475 fix key_name in ec2 and cloudstack The copy of the patch that failed is found in:
        Hide
        gigimon Oleg Suharev added a comment -

        Ok, this file created by git format-patch

        Show
        gigimon Oleg Suharev added a comment - Ok, this file created by git format-patch
        Hide
        kami Tomaz Muraus added a comment -

        Oleg Suharev Can you please generate the patch using git-format patch (https://libcloud.readthedocs.org/en/latest/development.html#attach-a-final-patch-with-your-changes-to-the-corresponding-jira-ticket) so we can preserve the commit authorship?

        Show
        kami Tomaz Muraus added a comment - Oleg Suharev Can you please generate the patch using git-format patch ( https://libcloud.readthedocs.org/en/latest/development.html#attach-a-final-patch-with-your-changes-to-the-corresponding-jira-ticket ) so we can preserve the commit authorship?
        Hide
        gigimon Oleg Suharev added a comment -

        I fix this and add this patch, please check and accept, thx.

        Show
        gigimon Oleg Suharev added a comment - I fix this and add this patch, please check and accept, thx.
        Hide
        kami Tomaz Muraus added a comment -

        For consistency, it should use underscore separates names. So "key_name" in this case.

        Show
        kami Tomaz Muraus added a comment - For consistency, it should use underscore separates names. So "key_name" in this case.

          People

          • Assignee:
            Unassigned
            Reporter:
            gigimon Oleg Suharev
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development