Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0-beta3
    • Component/s: Compute
    • Labels:
      None

      Description

      Add NephoScale cloud (nephoscale.com) driver support for libcloud

      1. nepho_libcloud.patch
        52 kB
        Markos Gogoulos
      2. nephoscale_driver.patch
        84 kB
        Markos Gogoulos

        Activity

        Hide
        kami Tomaz Muraus added a comment -

        Since this is going to be a bigger change, please make sure to file an ICLA (http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes) if you haven't done so yet.

        Show
        kami Tomaz Muraus added a comment - Since this is going to be a bigger change, please make sure to file an ICLA ( http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes ) if you haven't done so yet.
        Hide
        mgogoulos Markos Gogoulos added a comment -

        Forgot to mention that, I've filed the ICLA and received a
        confirmation from Apache!

        Στις 27.09.2013 15:16, Tomaz Muraus (JIRA)
        έγραψε:

        https://issues.apache.org/jira/browse/LIBCLOUD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779864#comment-13779864
        [2] ]
        ---------------------------------------
        bigger change, please make sure to file an ICLA
        (http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes
        [3]) if you haven't done so yet.
        --------------------- Key: LIBCLOUD-404 URL:
        https://issues.apache.org/jira/browse/LIBCLOUD-404 [1] Project: Libcloud
        Issue Type: New Feature Components: Compute Reporter: Markos Gogoulos
        Original Estimate: 96h Remaining Estimate: 96h Add NephoScale cloud
        (nephoscale.com) driver support for libcloud
        automatically generated by JIRA.
        please contact your JIRA administrators
        see: http://www.atlassian.com/software/jira [4]

        Links:
        ------
        [1]
        https://issues.apache.org/jira/browse/LIBCLOUD-404
        [2]
        https://issues.apache.org/jira/browse/LIBCLOUD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779864#comment-13779864
        [3]
        http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes
        [4]
        http://www.atlassian.com/software/jira

        Show
        mgogoulos Markos Gogoulos added a comment - Forgot to mention that, I've filed the ICLA and received a confirmation from Apache! Στις 27.09.2013 15:16, Tomaz Muraus (JIRA) έγραψε: https://issues.apache.org/jira/browse/LIBCLOUD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779864#comment-13779864 [2] ] --------------------------------------- bigger change, please make sure to file an ICLA ( http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes [3] ) if you haven't done so yet. --------------------- Key: LIBCLOUD-404 URL: https://issues.apache.org/jira/browse/LIBCLOUD-404 [1] Project: Libcloud Issue Type: New Feature Components: Compute Reporter: Markos Gogoulos Original Estimate: 96h Remaining Estimate: 96h Add NephoScale cloud (nephoscale.com) driver support for libcloud automatically generated by JIRA. please contact your JIRA administrators see: http://www.atlassian.com/software/jira [4] Links: ------ [1] https://issues.apache.org/jira/browse/LIBCLOUD-404 [2] https://issues.apache.org/jira/browse/LIBCLOUD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779864#comment-13779864 [3] http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes [4] http://www.atlassian.com/software/jira
        Hide
        kami Tomaz Muraus added a comment -

        Sounds good - then we should be all set to merge the patch once it has been reviewed.

        Show
        kami Tomaz Muraus added a comment - Sounds good - then we should be all set to merge the patch once it has been reviewed.
        Hide
        mgogoulos Markos Gogoulos added a comment -

        generated and attached the patch

        Show
        mgogoulos Markos Gogoulos added a comment - generated and attached the patch
        Hide
        kami Tomaz Muraus added a comment -

        Markos Gogoulos Thanks!

        Sorry for the additional work, but there are a couple of more issues which need to be checked and addressed. Especially point #3 here https://github.com/apache/libcloud/pull/153#discussion_r6769771

        Show
        kami Tomaz Muraus added a comment - Markos Gogoulos Thanks! Sorry for the additional work, but there are a couple of more issues which need to be checked and addressed. Especially point #3 here https://github.com/apache/libcloud/pull/153#discussion_r6769771
        Hide
        kami Tomaz Muraus added a comment -

        Also, before you generate a next patch, please make sure to squash all the commits into a single one.

        Show
        kami Tomaz Muraus added a comment - Also, before you generate a next patch, please make sure to squash all the commits into a single one.
        Hide
        mgogoulos Markos Gogoulos added a comment -

        I've fixed the issues and wish to generate the patch. Any hints on how I can squash all commits to a single one?

        Show
        mgogoulos Markos Gogoulos added a comment - I've fixed the issues and wish to generate the patch. Any hints on how I can squash all commits to a single one?
        Hide
        kami Tomaz Muraus added a comment -

        Markos Gogoulos http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

        Basically, you want to:

        git rebase -i <sha of the parent of your first commit>
        squash all the changes into your first commit

        Show
        kami Tomaz Muraus added a comment - Markos Gogoulos http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html Basically, you want to: git rebase -i <sha of the parent of your first commit> squash all the changes into your first commit
        Hide
        mgogoulos Markos Gogoulos added a comment -

        Attaching the patch with squashed commits

        Show
        mgogoulos Markos Gogoulos added a comment - Attaching the patch with squashed commits
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit da2fd8d859b7998bbfd99e4c61de1e62f8dea0e4 in branch refs/heads/trunk from Markos Gogoulos
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=da2fd8d ]

        LIBCLOUD-404: Add Nephoscale driver.

        Signed-off-by: Tomaz Muraus <tomaz@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit da2fd8d859b7998bbfd99e4c61de1e62f8dea0e4 in branch refs/heads/trunk from Markos Gogoulos [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=da2fd8d ] LIBCLOUD-404 : Add Nephoscale driver. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
        Hide
        kami Tomaz Muraus added a comment -

        Sorry for the delay, I was afk most of the time in the last couple of days.

        In any case, I went ahead and merged your changes into trunk.

        The last patch you attached was generated using "git diff" which doesn't preserve git history and commit author. Because of that I went ahead and used a "git format-patch" patch generated by Github (https://github.com/apache/libcloud/pull/153.patch) which I manually squashed.

        Patch also had a bunch of pep8 issues which I fixed in the trunk. Next time please make sure you do that.

        Show
        kami Tomaz Muraus added a comment - Sorry for the delay, I was afk most of the time in the last couple of days. In any case, I went ahead and merged your changes into trunk. The last patch you attached was generated using "git diff" which doesn't preserve git history and commit author. Because of that I went ahead and used a "git format-patch" patch generated by Github ( https://github.com/apache/libcloud/pull/153.patch ) which I manually squashed. Patch also had a bunch of pep8 issues which I fixed in the trunk. Next time please make sure you do that.
        Hide
        mgogoulos Markos Gogoulos added a comment -

        Nice, thanks!

        Show
        mgogoulos Markos Gogoulos added a comment - Nice, thanks!

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            mgogoulos Markos Gogoulos
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 96h
              96h
              Remaining:
              Remaining Estimate - 96h
              96h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development