Since this is going to be a bigger change, please make sure to file an ICLA (http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes) if you haven't done so yet.

Forgot to mention that, I've filed the ICLA and received a
confirmation from Apache!

Στις 27.09.2013 15:16, Tomaz Muraus (JIRA)
έγραψε:

https://issues.apache.org/jira/browse/LIBCLOUD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779864#comment-13779864
[2] ]
---------------------------------------
bigger change, please make sure to file an ICLA
(http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes
[3]) if you haven't done so yet.
--------------------- Key: LIBCLOUD-404 URL:
https://issues.apache.org/jira/browse/LIBCLOUD-404 [1] Project: Libcloud
Issue Type: New Feature Components: Compute Reporter: Markos Gogoulos
Original Estimate: 96h Remaining Estimate: 96h Add NephoScale cloud
(nephoscale.com) driver support for libcloud
automatically generated by JIRA.
please contact your JIRA administrators
see: http://www.atlassian.com/software/jira [4]

Links:
------
[1]
https://issues.apache.org/jira/browse/LIBCLOUD-404
[2]
https://issues.apache.org/jira/browse/LIBCLOUD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779864#comment-13779864
[3]
http://ci.apache.org/projects/libcloud/docs/development.html#contributing-bigger-changes
[4]
http://www.atlassian.com/software/jira

Sounds good - then we should be all set to merge the patch once it has been reviewed.

generated and attached the patch

Markos Gogoulos Thanks!

Sorry for the additional work, but there are a couple of more issues which need to be checked and addressed. Especially point #3 here https://github.com/apache/libcloud/pull/153#discussion_r6769771

Also, before you generate a next patch, please make sure to squash all the commits into a single one.

I've fixed the issues and wish to generate the patch. Any hints on how I can squash all commits to a single one?

Markos Gogoulos http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Basically, you want to:

git rebase -i <sha of the parent of your first commit>
squash all the changes into your first commit

Attaching the patch with squashed commits

Commit da2fd8d859b7998bbfd99e4c61de1e62f8dea0e4 in branch refs/heads/trunk from Markos Gogoulos
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=da2fd8d ]

LIBCLOUD-404: Add Nephoscale driver.

Signed-off-by: Tomaz Muraus <tomaz@apache.org>

Sorry for the delay, I was afk most of the time in the last couple of days.

In any case, I went ahead and merged your changes into trunk.

The last patch you attached was generated using "git diff" which doesn't preserve git history and commit author. Because of that I went ahead and used a "git format-patch" patch generated by Github (https://github.com/apache/libcloud/pull/153.patch) which I manually squashed.

Patch also had a bunch of pep8 issues which I fixed in the trunk. Next time please make sure you do that.

Nice, thanks!