Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-382

Add support for floating IPs to OpenStack

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0-beta3
    • Component/s: Compute
    • Labels:

      Description

      OpenStack has floating IPs, but they are not currently supported.
      Add support for this feature to OpenStack driver.

        Activity

        Hide
        ikusalic Ivan added a comment -

        I've created a patch for this feature.
        While I tried to adhere to the current conventions, tell me if something is wrong.

        Show
        ikusalic Ivan added a comment - I've created a patch for this feature. While I tried to adhere to the current conventions, tell me if something is wrong.
        Hide
        ikusalic Ivan added a comment - - edited

        Patch to implement this feature.

        Show
        ikusalic Ivan added a comment - - edited Patch to implement this feature.
        Hide
        kami Tomaz Muraus added a comment -

        There were are a couple of pep8 / style issues which I have fixed. Besides that patch looked good, so I've merged it into master.

        It would also be great if you could add some usage examples to our new documentation - https://github.com/apache/libcloud/blob/trunk/docs/compute/examples.rst

        Thanks.

        Show
        kami Tomaz Muraus added a comment - There were are a couple of pep8 / style issues which I have fixed. Besides that patch looked good, so I've merged it into master. It would also be great if you could add some usage examples to our new documentation - https://github.com/apache/libcloud/blob/trunk/docs/compute/examples.rst Thanks.
        Hide
        ikusalic Ivan added a comment -

        Sure, here is a simple usage example.

        Sorry about pep8, I've disabled 2 or 3 errors in vim, and forgot to check for those.

        Show
        ikusalic Ivan added a comment - Sure, here is a simple usage example. Sorry about pep8, I've disabled 2 or 3 errors in vim, and forgot to check for those.
        Hide
        kami Tomaz Muraus added a comment -
        Show
        kami Tomaz Muraus added a comment - Thanks, I've merged it into trunk and fixed a minor syntax error - https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=blobdiff;f=docs/examples/compute/openstack_floating_ips.py;h=203e3eae506341c17fa6d9ee189dfb43c18f8ac4;hp=d7afe3f79cd2e86720648d251cce4b157faf9dd1;hb=d26c9a6;hpb=6ab58f2e035db15aa2eb10bd97527499bb42defa . Your syntax would only work if a list returned by the function only has a single element.
        Hide
        ikusalic Ivan added a comment -

        Ah, yes, sorry. That's what you get from doing things late on friday.

        Show
        ikusalic Ivan added a comment - Ah, yes, sorry. That's what you get from doing things late on friday.

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            ikusalic Ivan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development