Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-375

Unify ex argument for security groups of create_node for AWS and OpenStack

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0-beta3
    • Component/s: Compute
    • Labels:
      None

      Description

      When creating a new node, OpenStack and AWS use different names for ex argument for security groups although the underlying feature is the same.

      OpenStack uses 'ex_security_groups'
      AWS uses 'ex_securitygroup'

      Proposed solution: rename AWS argument to match OpenStack's. (as both support multiple groups)
      https://github.com/ikusalic/libcloud/compare/unify-ex-security-groups

      If this is problem because it is not backwards compatible, maybe adding alias 'ex_security_groups' to AWS makes sense.

        Activity

        Hide
        kami Tomaz Muraus added a comment -

        Merged a patch which unifies the arguments into trunk.

        Show
        kami Tomaz Muraus added a comment - Merged a patch which unifies the arguments into trunk.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f6239257287cc1303dd3ee77f224f7d529d4066d in branch refs/heads/trunk from Tomaz Muraus
        [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=f623925 ]

        Modify EC2 driver create_node method and make extension argument for assigning
        a node to a security group consistent with the OpenStack implementation.

        Previously the argument was called ex_securitygroup, now it's called
        ex_security_groups.

        Part of LIBCLOUD-375.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f6239257287cc1303dd3ee77f224f7d529d4066d in branch refs/heads/trunk from Tomaz Muraus [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=f623925 ] Modify EC2 driver create_node method and make extension argument for assigning a node to a security group consistent with the OpenStack implementation. Previously the argument was called ex_securitygroup, now it's called ex_security_groups. Part of LIBCLOUD-375 .
        Hide
        kami Tomaz Muraus added a comment -

        Yeah, inconsistency is bad.

        I agree that we should use the same argument name for both of the providers. I'll dig into it later tonight.

        Backward compatibility shouldn't be a problem, because like you said, we can leave ex_securitygroup alias there.

        Show
        kami Tomaz Muraus added a comment - Yeah, inconsistency is bad. I agree that we should use the same argument name for both of the providers. I'll dig into it later tonight. Backward compatibility shouldn't be a problem, because like you said, we can leave ex_securitygroup alias there.

          People

          • Assignee:
            Unassigned
            Reporter:
            ikusalic Ivan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development