Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-326

EC2 : ex_describe_keypairs should also return fingerprint

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Compute
    • Labels:
      None

      Description

      {{
      keypairs = conn.ex_describe_all_keypairs ()
      for kp in keypairs :
      keypair = conn.ex_describe_keypairs (kp)
      pprint (keypair)
      }}

      results in

      {{

      {'keyName': 'futuregrid'}

      }}

      but should result in:

      {{

      {'keyName': 'futuregrid', 'keyFingerprint': '00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00'}

      }}

      This should be easy to change in https://svn.apache.org/viewvc/libcloud/trunk/libcloud/compute/drivers/ec2.py?view=markup line 819 by adding something like

      {{
      key_name = findattr(element=response, xpath='keySet/item/keyName',
      namespace=NAMESPACE)
      return

      { 'keyName': key_name }

      }}

      to
      {{
      key_name = findattr(element=response, xpath='keySet/item/keyName',
      namespace=NAMESPACE)
      key_fp = findattr(element=response, xpath='keySet/item/keyFingerprint',
      namespace=NAMESPACE)
      return

      { 'keyName' : key_name 'keyFingerprint': key_fp }

      }}

      or so...

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1484194 from Tomaz Muraus
        [ https://svn.apache.org/r1484194 ]

        For consistency rename "ex_describe_keypairs" method to "ex_describe_keypair".

        Also modify "ex_describe_keypair" method to return key fingerprint in the return
        value.

        Part of LIBCLOUD-326.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1484194 from Tomaz Muraus [ https://svn.apache.org/r1484194 ] For consistency rename "ex_describe_keypairs" method to "ex_describe_keypair". Also modify "ex_describe_keypair" method to return key fingerprint in the return value. Part of LIBCLOUD-326 .
        Hide
        kami Tomaz Muraus added a comment -

        Added this functionality + tests in 0.12.x branch.

        Thanks.

        Show
        kami Tomaz Muraus added a comment - Added this functionality + tests in 0.12.x branch. Thanks.
        Hide
        andre.merzky Andre Merzky added a comment -

        Hey, this was quick – thanks!

        A.

        Show
        andre.merzky Andre Merzky added a comment - Hey, this was quick – thanks! A.

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            andre.merzky Andre Merzky
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development