Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.1
    • Component/s: Compute

      Description

      between Opennebula 3.2 and 3.8, at least 2 things changed :

      • size listing need sub-requests
        information is no longer available on /instance_type hit
        it is needed to iterate over /instance_type/$N
      • plain auth
        possibility to use non sha1 auth header for incompatible reverse-proxy

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1444350 from Tomaz Muraus
        [ https://svn.apache.org/r1444350 ]

        Add support for OpenNebula 3.8.

        Contributed by Guillaume ZITTA, part of LIBCLOUD-295.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1444350 from Tomaz Muraus [ https://svn.apache.org/r1444350 ] Add support for OpenNebula 3.8. Contributed by Guillaume ZITTA, part of LIBCLOUD-295 .
        Hide
        kami Tomaz Muraus added a comment -

        Thanks for the patch. I've made the following changes and merged it into trunk:

        • pep8 style fixes
        • Changed variable name from "ids" to "size_id". Having a plural name for a variable which isn't a collection is deceiving and confusing.
        • Refactored _to_sizes to reduce amount of repeated code.
        • Improved assertions in the test - doing a loosely assertion like "self.assertTrue(size.cpu is None or isinstance(size.cpu, float))" is unnecessary and doesn't make sense. Tests use fixtures so the order in which sizes are returned is deterministic.

        Next time please also follow the contribution guidelines described at http://libcloud.apache.org/contributing.html. You submitted a git formatted patch which can't be applied directly to a SVN tree so this means more work for us.

        Show
        kami Tomaz Muraus added a comment - Thanks for the patch. I've made the following changes and merged it into trunk: pep8 style fixes Changed variable name from "ids" to "size_id". Having a plural name for a variable which isn't a collection is deceiving and confusing. Refactored _to_sizes to reduce amount of repeated code. Improved assertions in the test - doing a loosely assertion like "self.assertTrue(size.cpu is None or isinstance(size.cpu, float))" is unnecessary and doesn't make sense. Tests use fixtures so the order in which sizes are returned is deterministic. Next time please also follow the contribution guidelines described at http://libcloud.apache.org/contributing.html . You submitted a git formatted patch which can't be applied directly to a SVN tree so this means more work for us.

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            gza Guillaume ZITTA
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development