Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-292

create_node fails on Openstack driver when Nova enable_instance_password=false

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.2
    • Fix Version/s: 0.12.1
    • Component/s: Compute
    • Labels:
      None

      Description

      For the Openstack driver. As noted in:

      http://docs.openstack.org/essex/openstack-compute/admin/content/configuring-compute-API.html#d6e1833

      Nova can be configured via the "enable_instance_password" parameter to not bother trying to inject the admin password for Hypervisors that do not support that (by default it does try to). In this case, the response from Nova does not include the adminPass parameter, so the create_node function fails while parsing the response.

      (trival) patch follows.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1443198 from Tomaz Muraus
        [ https://svn.apache.org/r1443198 ]

        Fix create_node in OpenStack driver to work correctly if 'adminPass'
        attribute is not present in the response.

        Contributed by Gavin McCance, part of LIBCLOUD-292.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1443198 from Tomaz Muraus [ https://svn.apache.org/r1443198 ] Fix create_node in OpenStack driver to work correctly if 'adminPass' attribute is not present in the response. Contributed by Gavin McCance, part of LIBCLOUD-292 .
        Hide
        kami Tomaz Muraus added a comment -

        Added a comment and a test case and merged it into trunk.

        Next time please make sure to include the test yourself. This issue is exactly one of the many reasons why tests for edge cases are really important

        Thanks!

        Show
        kami Tomaz Muraus added a comment - Added a comment and a test case and merged it into trunk. Next time please make sure to include the test yourself. This issue is exactly one of the many reasons why tests for edge cases are really important Thanks!

          People

          • Assignee:
            kami Tomaz Muraus
            Reporter:
            gmccance Gavin McCance
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development