Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-187

Allow multiple entries into .ssh/authorized_keys by changing put() to specify append mode

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Compute
    • Labels:
      None

      Activity

      Hide
      kami Tomaz Muraus added a comment -

      This won't work - this calls "put" method on the ParamikoSSHClient object and the put method on the ParamikoSSHClient class doesn't take "mode" keyword argument - https://github.com/apache/libcloud/blob/trunk/libcloud/compute/ssh.py#L150

      Show
      kami Tomaz Muraus added a comment - This won't work - this calls "put" method on the ParamikoSSHClient object and the put method on the ParamikoSSHClient class doesn't take "mode" keyword argument - https://github.com/apache/libcloud/blob/trunk/libcloud/compute/ssh.py#L150
      Hide
      jaydoane Jay Doane added a comment -

      Sorry, I got my patch submissions out of order. I've submitted another one that should go first.

      Show
      jaydoane Jay Doane added a comment - Sorry, I got my patch submissions out of order. I've submitted another one that should go first.
      Hide
      kami Tomaz Muraus added a comment - - edited

      Looks better, thanks. I've merged both patches (LIBCLOUD-187 and LIBCLOUD-188) into trunk with some minor changes:

      • add 'mode' argument to the BaseSSHClient put method
      • updated affected test - tests/compute/test_deployment.py
      Show
      kami Tomaz Muraus added a comment - - edited Looks better, thanks. I've merged both patches ( LIBCLOUD-187 and LIBCLOUD-188 ) into trunk with some minor changes: add 'mode' argument to the BaseSSHClient put method updated affected test - tests/compute/test_deployment.py

        People

        • Assignee:
          Unassigned
          Reporter:
          jaydoane Jay Doane
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development