Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.1
    • Component/s: Core
    • Labels:

      Description

      Notably missing from libcloud's DNS drivers is support for Amazon Route 53.

      https://github.com/apache/libcloud/tree/trunk/libcloud/dns/drivers

      This should be pretty easy to implement. There is some existing code available from projects like boto, Cirrus, and cli53.

      I am thinking of implementing it since it is useful for me (at my company we use both Amazon Route 53 + Rackspace Cloud DNS).

      Let me know if someone has already started working on this.

        Activity

        Hide
        John Carr added a comment -

        Sorry about that, they past until that last round of pep8 changes Will be more careful next time.

        Show
        John Carr added a comment - Sorry about that, they past until that last round of pep8 changes Will be more careful next time.
        Hide
        Tomaz Muraus added a comment -

        Thanks!

        I've changed and fixed some things and merged the patch into master (https://svn.apache.org/viewvc?view=revision&revision=1429425). Some things I've changed:

        • pep8 + style stuff
        • httplib constants
        • fixed tests (a bunch of them failed)
        • fixed broken code
        • added docstrings

        I still plan to add some missing docstrings tomorrow after I get some sleep.

        Next time please at least make sure the tests pass before you submit a patch.

        Show
        Tomaz Muraus added a comment - Thanks! I've changed and fixed some things and merged the patch into master ( https://svn.apache.org/viewvc?view=revision&revision=1429425 ). Some things I've changed: pep8 + style stuff httplib constants fixed tests (a bunch of them failed) fixed broken code added docstrings I still plan to add some missing docstrings tomorrow after I get some sleep. Next time please at least make sure the tests pass before you submit a patch.
        Hide
        John Carr added a comment -

        Attaching patch as requested in pull request.

        Show
        John Carr added a comment - Attaching patch as requested in pull request.
        Hide
        John Carr added a comment -
        Show
        John Carr added a comment - Here you go: https://github.com/apache/libcloud/pull/83
        Hide
        Tomaz Muraus added a comment -

        Can you please attach a patch here or open a PR on github so I can add comments to the whole diff?

        Thanks

        Show
        Tomaz Muraus added a comment - Can you please attach a patch here or open a PR on github so I can add comments to the whole diff? Thanks
        Hide
        Tomaz Muraus added a comment -

        Awesome!

        Will review it today

        Show
        Tomaz Muraus added a comment - Awesome! Will review it today
        Hide
        John Carr added a comment -

        Updated with tests, and much better compliance with libcloud interface.

        Show
        John Carr added a comment - Updated with tests, and much better compliance with libcloud interface.
        Hide
        Tomaz Muraus added a comment -

        Cool.

        Let us know if you need any help with tests, I would definitely love to see full support for Route53 in trunk

        Show
        Tomaz Muraus added a comment - Cool. Let us know if you need any help with tests, I would definitely love to see full support for Route53 in trunk
        Hide
        John Carr added a comment -

        I've update that branch with my latest fixes. Obviosuly, tests are still to do

        I still don't think update_zone makes sense for AWS, for the same reasons as before.

        Show
        John Carr added a comment - I've update that branch with my latest fixes. Obviosuly, tests are still to do I still don't think update_zone makes sense for AWS, for the same reasons as before.
        Hide
        John Carr added a comment -

        Here is where I am so far:

        https://github.com/Jc2k/libcloud/compare/route53

        AFAICT, update_zone makes little sense on AWS. There are only 'master' zones, and there is no such thing as a zone-wide ttl.

        I'm blocked on issue 259 - i'm unsure what the correct behaviour for create_record actually is.

        Show
        John Carr added a comment - Here is where I am so far: https://github.com/Jc2k/libcloud/compare/route53 AFAICT, update_zone makes little sense on AWS. There are only 'master' zones, and there is no such thing as a zone-wide ttl. I'm blocked on issue 259 - i'm unsure what the correct behaviour for create_record actually is.
        Hide
        Tomaz Muraus added a comment -

        John Carr - have a look at the file - https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/route53.py. I think it's missing all of the create, update and remove methods + tests.

        Show
        Tomaz Muraus added a comment - John Carr - have a look at the file - https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/route53.py . I think it's missing all of the create, update and remove methods + tests.
        Hide
        John Carr added a comment -

        What is needed to finish the Route53 driver that is currently in libcloud but disactivated?

        Show
        John Carr added a comment - What is needed to finish the Route53 driver that is currently in libcloud but disactivated?
        Hide
        Ryan Lewon added a comment -

        Working on a patch.

        Show
        Ryan Lewon added a comment - Working on a patch.
        Hide
        Tomaz Muraus added a comment -

        As far as I know, nobody is working on it at the moment so it's all yours

        Also keep in mind that the driver shouldn't depend on external libraries such as boto.

        Show
        Tomaz Muraus added a comment - As far as I know, nobody is working on it at the moment so it's all yours Also keep in mind that the driver shouldn't depend on external libraries such as boto.

          People

          • Assignee:
            Tomaz Muraus
            Reporter:
            Andrew Montalenti
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development